Backmerge Commcare 2.61.4

[Jignesh-dimagi]

Product Description

Backmerge Commcare 2.61.4

Labels and Review

• Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
• Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request refactors the push notification system and bumps the version to 2.61.4. It introduces a migration path for push notification channel IDs by adding new constants and deleting the old channel, then recreating it with higher priority (DEFAULT to HIGH). The core change consolidates the notification sync API by replacing multiple NotificationsSyncWorkerManager constructors with a single parameterized constructor and introducing new startSyncWorker(s) entry points for handling notification payloads. Related updates propagate to PushNotificationViewModel and CommCareFirebaseMessagingService to use the new API. Notification priority is elevated to PRIORITY_MAX and channel references are updated. An early return optimization is added to skip unnecessary server calls in PushNotificationApiHelper when no notification IDs are present.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• CI-467 - Send message bug solved #3512: Makes identical code-level changes to push-notification flow including NotificationsSyncWorkerManager refactoring and PushNotificationViewModel updates.
• Separated the logic for channel keys in worker #3397: Modifies NotificationsSyncWorkerManager scheduling API and constructor patterns.
• Jignesh/feat/ccct 1718 #3373: Adds PushNotificationApiHelper.convertPNRecordsToPayload which is now consumed in this PR.

Suggested labels

QA Note

Suggested reviewers

• shubham1g5
• conroy-ricketts
• OrangeAndGreen

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 31.25% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	⚠️ Warning	The PR description lacks critical technical details and safety assurances required by the template for a backmerge involving notification channel priority changes and API refactoring.	Add Technical Summary with links to relevant tickets, Safety story detailing testing performed, Automated test coverage details, and QA Plan. Complete the Labels and Review checklist with specific answers.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Backmerge Commcare 2.61.4' directly describes the main objective of the PR (merging version 2.61.4 into master) and aligns with the actual changeset containing version bumps and related fixes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch commcare_2.61

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[shubham1g5]

Once you have made the release tag, this should change back to 2.62 on this branch so that we keep the master version set to the upcoming release, would also be nice to update hotfix doc to reflect this step.

[Jignesh-dimagi]

Ok, I was thinking to give another PR for 2.62 as mentioned in ticket description so that release branch is alway clean.

[Jignesh-dimagi]

Ok, I was thinking to give another PR for 2.62 as mentioned in ticket description so that release branch is alway clean.

Changed in commcare_2.61 branch only