CCCT-1985 Updated no data messages in different screen's #3506

jaypanchal-13 · 2026-01-21T12:41:22Z

Product Description

Ticket -> https://dimagi.atlassian.net/browse/CCCT-1985

Changed no data msg in multiple screen's

Screen Shot -> Left -> before screenshot and right -> after screenshot

Technical Summary

Feature Flag

Safety Assurance

Safety story

Automated test coverage

QA Plan

Labels and Review

Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
Risk label is set correctly
The set of people pinged as reviewers is appropriate for the level of risk of the change

coderabbitai · 2026-01-21T12:46:03Z

📝 Walkthrough

Walkthrough

This change updates user-facing strings and layout attributes across multiple language resource files. The primary modification is renaming the notification string resource from pn_no_notification_found to pn_no_notification_available with revised message text in English and ten localized variants (Spanish, French, Hindi, Lithuanian, Norwegian, Portuguese, Swahili, Tigrinya, and others). Additional strings like connect_no_jobs, personalid_work_history_no_records_available, and no_channel_msg are similarly updated with reworded messaging. A layout XML file has attribute adjustments applied to the tvNoWorkHistoryAvailable view, including margin and padding removals and color/constraint modifications.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

PR #3120 — Modifies the same French strings resource file and includes the pn_no_notification_found → pn_no_notification_available string rename.
PR #3344 — Modifies app/res/layout/fragment_work_history_earned.xml and adjusts the tvNoWorkHistoryAvailable view attributes.
PR #3269 — Updates the same pn_no_notification_found → pn_no_notification_available string resource rename across language variants.

Suggested labels

Release Note, QA Note

Suggested reviewers

OrangeAndGreen
Jignesh-dimagi
shubham1g5
conroy-ricketts

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The PR description is incomplete. While it references the ticket and provides screenshots, critical sections lack detail or explanation.	Please provide more context in Technical Summary explaining the rationale for messaging changes, and complete Safety Assurance sections (Safety story, Automated test coverage, QA Plan) to substantiate that this change is regression-free.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title clearly relates to the main changes in the PR, which involve updating empty-state messages across multiple screens and layouts.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch CCCT-1985-update-empty-screen-text

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

app/res/layout/fragment_work_history_earned.xml (1)
8-18: Avoid hardcoded black text color.

If the parent background changes (e.g., dark theme), black text can become unreadable. Prefer a theme attribute so the empty-state text adapts to the active theme.
🛠️ Suggested change
-        android:textColor="@color/black"
+        android:textColor="?attr/textColorPrimary"

🤖 Fix all issues with AI agents

In `@app/res/values-ti/strings.xml`:
- Line 292: The Tigrinya string identified by name "connect_no_jobs" contains
stray Thai characters (“ปรากฏ”) and must be replaced with the correct Tigrinya
text via the localization process; locate the <string name="connect_no_jobs">
entry and update its value to the proper Tigrinya translation (using your
i18n/localization workflow or translator) so the sentence is entirely in
Tigrinya and free of mixed-script characters.

coderabbitai · 2026-01-21T12:46:06Z

app/res/values-ti/strings.xml

    <string name="connect_last_update">ዝተመሓየሸ: %s</string>
    <string name="connect_title">ኣራኽብ</string>
-    <string name="connect_no_jobs">ኣብ ዝኾነ ንጡፍ ዕድላት ኣይተዓደምኩምን። በይዛኹም ፀኒሕኹም ተመለሱ።</string>
+    <string name="connect_no_jobs">ንሕጂ ናብ ዝኾነ ዕድላት ኣይተዓደምካን። ሓንሳብ ናብ ዕድል ምስ ተዓደምካ፡ ኣብዚ ዝርዝር ክปรากฏ እዩ።</string>


⚠️ Potential issue | 🟡 Minor

Fix mixed-script text in Tigrinya string.

The connect_no_jobs translation includes Thai characters (“ปรากฏ”), which looks like an accidental copy/paste and will read incorrectly to Tigrinya users. Please replace with the correct Tigrinya wording via your localization workflow.

🤖 Prompt for AI Agents

In `@app/res/values-ti/strings.xml` at line 292, The Tigrinya string identified by name "connect_no_jobs" contains stray Thai characters (“ปรากฏ”) and must be replaced with the correct Tigrinya text via the localization process; locate the <string name="connect_no_jobs"> entry and update its value to the proper Tigrinya translation (using your i18n/localization workflow or translator) so the sentence is entirely in Tigrinya and free of mixed-script characters.

@jaypanchal-13 can we verify this

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

Jignesh-dimagi · 2026-01-21T12:45:51Z

app/res/values-fr/strings.xml

    <string name="connect_last_update">Mis à jour: %s</string>
    <string name="connect_title">Connecter</string>
-    <string name="connect_no_jobs">Vous n\'avez été invité à aucune opportunité active. Veuillez revenir plus tard.</string>
+    <string name="connect_no_jobs">Vous n’avez encore été invité à aucune opportunité. Une fois que vous êtes invité à une opportunité, elle apparaîtra dans cette liste.</string>


It has missing \ in n\’avez.

@Jignesh-dimagi Yes but it is not showing or throwing any error.

This might be a difference in the actual characters, between ’ (unicode 8217) and ' (ASCII 39)
It looks like AS only wants the ASCII char to be escaped. But I think we should be consistent in which one we use, and since other places use ' we should use it here also (with the \)

Jignesh-dimagi · 2026-01-21T12:50:22Z

@jaypanchal-13 Just a thought: All screen has different UI (text size, color, gravity) to show the empty screen. Shouldn't we make it uniform across all the screen?

jaypanchal-13 · 2026-01-21T13:16:04Z

connect_no_jobs

@Jignesh-dimagi Can you check again is it look fine or need changes?

app/res/layout/fragment_connect_jobs_list.xml

conroy-ricketts · 2026-01-21T15:52:24Z

app/res/values-ti/strings.xml

    <string name="connect_last_update">ዝተመሓየሸ: %s</string>
    <string name="connect_title">ኣራኽብ</string>
-    <string name="connect_no_jobs">ኣብ ዝኾነ ንጡፍ ዕድላት ኣይተዓደምኩምን። በይዛኹም ፀኒሕኹም ተመለሱ።</string>
+    <string name="connect_no_jobs">ንሕጂ ናብ ዝኾነ ዕድላት ኣይተዓደምካን። ሓንሳብ ናብ ዕድል ምስ ተዓደምካ፡ ኣብዚ ዝርዝር ክปรากฏ እዩ።</string>


@jaypanchal-13 can we verify this

OrangeAndGreen

Added a couple things to check, and looks like Conroy identified an important one also

OrangeAndGreen · 2026-01-21T16:33:50Z

app/res/values-fr/strings.xml

    <string name="connect_last_update">Mis à jour: %s</string>
    <string name="connect_title">Connecter</string>
-    <string name="connect_no_jobs">Vous n\'avez été invité à aucune opportunité active. Veuillez revenir plus tard.</string>
+    <string name="connect_no_jobs">Vous n’avez encore été invité à aucune opportunité. Une fois que vous êtes invité à une opportunité, elle apparaîtra dans cette liste.</string>


This might be a difference in the actual characters, between ’ (unicode 8217) and ' (ASCII 39)
It looks like AS only wants the ASCII char to be escaped. But I think we should be consistent in which one we use, and since other places use ' we should use it here also (with the \)

OrangeAndGreen · 2026-01-21T16:36:29Z

app/res/values/strings.xml


    <string name="personalid_authentication_failed">Authenticating the biometrics on your Android device has failed. Please apply any available system updates, or try again with a different device</string>
-    <string name="no_channel_msg">You have no current messaging channels</string>
+    <string name="no_channel_msg">You’re not subscribed to any messaging channels</string>


Perhaps a better question for the product team...

When I imagine seeing this message as a user the first thing that comes to mind is "How do I subscribe to some messaging channels?"

Perhaps the message should be more like the one for the opportunity list and include text like "Once you've been invited to a messaging channel, it will appear in this list."

@OrangeAndGreen Asked in slack here

shubham1g5 · 2026-01-21T20:59:05Z

@jaypanchal-13 I see that all those screenshots are following different text styles and margins and it would be great to use a consistent style here.

Jignesh-dimagi · 2026-01-22T07:30:45Z

@Jignesh-dimagi Can you check again is it look fine or need changes?

@jaypanchal-13 It's nearly there; it's just that the margins are different. You can also confirm the style from Brendon.

jaypanchal-13 · 2026-01-22T07:44:07Z

@jaypanchal-13 I see that all those screenshots are following different text styles and margins and it would be great to use a consistent style here.

@shubham1g5 Left side is before screen shot and right side is after screen shot. Can you check now. For same I have messaged Brandon here in slack

conroy-ricketts

This looks great to me as long as Product does not request any additional changes 👍

app/res/values-fr/strings.xml

…pty-screen-text

Updated no data messages in different screen's

70027fd

jaypanchal-13 requested review from Jignesh-dimagi, OrangeAndGreen, conroy-ricketts and shubham1g5 January 21, 2026 12:41

coderabbitai bot reviewed Jan 21, 2026

View reviewed changes

Jignesh-dimagi reviewed Jan 21, 2026

View reviewed changes

nit

b0dbd0c

conroy-ricketts reviewed Jan 21, 2026

View reviewed changes

OrangeAndGreen requested changes Jan 21, 2026

View reviewed changes

Comment's addressed

76360f3

conroy-ricketts previously approved these changes Jan 22, 2026

View reviewed changes

app/res/values-fr/strings.xml Outdated Show resolved Hide resolved

jaypanchal-13 added 2 commits January 23, 2026 10:13

Merge remote-tracking branch 'origin/master' into CCCT-1985-update-em…

019d755

…pty-screen-text

nit

4fb03af

jaypanchal-13 dismissed conroy-ricketts’s stale review via 4fb03af January 23, 2026 04:43

jaypanchal-13 added 2 commits January 27, 2026 10:15

Merge remote-tracking branch 'origin/master' into CCCT-1985-update-em…

f24a4df

…pty-screen-text

Updates as per brandon suggestion

ae1ed7e

shubham1g5 previously approved these changes Jan 27, 2026

View reviewed changes

shubham1g5 requested review from Jignesh-dimagi and OrangeAndGreen January 27, 2026 07:05

Jignesh-dimagi previously approved these changes Jan 27, 2026

View reviewed changes

Updated no channel message

e68682a

jaypanchal-13 dismissed stale reviews from Jignesh-dimagi and shubham1g5 via e68682a January 27, 2026 13:10

jaypanchal-13 requested review from Jignesh-dimagi, conroy-ricketts and shubham1g5 January 27, 2026 13:12

shubham1g5 approved these changes Jan 27, 2026

View reviewed changes

Jignesh-dimagi approved these changes Jan 27, 2026

View reviewed changes

conroy-ricketts approved these changes Jan 27, 2026

View reviewed changes

Merge branch 'master' into CCCT-1985-update-empty-screen-text

8da1c40

jaypanchal-13 changed the title ~~Updated no data messages in different screen's~~ CCCT-1985 Updated no data messages in different screen's Jan 29, 2026

OrangeAndGreen approved these changes Jan 29, 2026

View reviewed changes

jaypanchal-13 merged commit f0dcb1d into master Jan 29, 2026
7 checks passed

Uh oh!

CCCT-1985 Updated no data messages in different screen's #3506

CCCT-1985 Updated no data messages in different screen's #3506

Uh oh!

Conversation

jaypanchal-13 commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Product Description

Technical Summary

Feature Flag

Safety Assurance

Safety story

Automated test coverage

QA Plan

Labels and Review

Uh oh!

coderabbitai bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jignesh-dimagi commented Jan 21, 2026

Uh oh!

jaypanchal-13 commented Jan 21, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OrangeAndGreen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shubham1g5 commented Jan 21, 2026

Uh oh!

Jignesh-dimagi commented Jan 22, 2026

Uh oh!

jaypanchal-13 commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conroy-ricketts left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jaypanchal-13 commented Jan 21, 2026 •

edited

Loading

coderabbitai bot commented Jan 21, 2026 •

edited

Loading

coderabbitai bot Jan 21, 2026 •

edited

Loading

jaypanchal-13 commented Jan 22, 2026 •

edited

Loading