Skip to content

Conversation

@jaypanchal-13
Copy link
Contributor

Product Description

Ticket-> https://dimagi.atlassian.net/browse/CCCT-2034

Technical Summary

Updated png to svg images

Screen Shot ->
Screenshot_20260112_142753

Feature Flag

Safety Assurance

Safety story

Automated test coverage

QA Plan

Labels and Review

  • Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
  • Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

Comment on lines +2 to +3
android:width="45dp"
android:height="45dp"
Copy link
Contributor

@shubham1g5 shubham1g5 Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are you getting these values for width and height from ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubham1g5 It is getting added by default as we download svg images

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

download from where ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, thanks for confirming.

Copy link
Contributor

@conroy-ricketts conroy-ricketts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @jaypanchal-13, are we not including the download icon as mentioned here?

@jaypanchal-13
Copy link
Contributor Author

LGTM, but @jaypanchal-13, are we not including the download icon as mentioned here?

@conroy-ricketts because it is already added and used in this PR

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

This pull request adds four new Android vector drawable XML resources to the app's drawable directory. The drawables include ic_connect_delivery.xml, ic_connect_learning.xml, ic_connect_new_opportunity.xml, and local_library.xml. Each drawable defines a UI icon with specific dimensions, fill colors, and path data. These are static asset files with no executable logic or runtime behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

skip-integration-tests

Suggested reviewers

  • Jignesh-dimagi
  • OrangeAndGreen
  • conroy-ricketts
🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete; critical sections like Safety story, Automated test coverage, and QA Plan contain only placeholder comments with no actual content provided. Complete the Safety Assurance section with details on testing approach, confirm no regressions exist, and provide specifics on the QA plan.
Title check ❓ Inconclusive The title 'Updated image to svg' is vague and generic, using non-descriptive language that doesn't convey specific information about which images were updated or the scope of changes. Replace with a more specific title such as 'Replace PNG icons with SVG drawables' or 'Convert drawable assets from PNG to SVG format'.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch CCCT-2034-change-to-svg-icon

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jaypanchal-13 jaypanchal-13 merged commit 0b49060 into master Jan 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants