Make trace nullable when stopping tracing

[avazirna]

Product Description

Minor improvement to make stopping tracing null-safe.

Labels and Review

• Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
• Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request modifies the CCPerfMonitoring.kt file to accept nullable Trace parameters in two methods: stopTracing and stopFileEncryptionTracing. The changes update method signatures to allow Trace? instead of Trace, and introduce safe-call operators (such as trace?.putAttribute, trace?.stop, and trace?.name) throughout both methods to handle null values gracefully without throwing NullPointerExceptions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

• [Hotfix] Add perf monitoring trace for file encryption time #3496: Modifies the same performance-monitoring code (CCPerfMonitoring.kt), adding file-encryption tracing and constants while this PR updates the nullable safety of tracing stop methods.
• Log exceptions when stop tracing #3367: Updates how tracing stop is handled by adding logging around calls to stopTracing, complementing this PR's changes to make those same methods nullable-safe.

Suggested reviewers

• shubham1g5
• conroy-ricketts
• Jignesh-dimagi

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is incomplete; it lacks critical sections including Product Description detail, Technical Summary with rationale, Safety Assurance with testing coverage, and QA Plan details required by the template.	Expand the description to include the rationale for the change, detailed testing coverage, QA verification plan, and context from the related ticket or document.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: making trace nullable when stopping tracing, which aligns with the file modifications updating method signatures to accept Trace?.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch make-trace-null-safe-when-stopping-trace

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}