Remove results list screen as it's not used anywhere

[shubham1g5]

Product Description

Code Cleanup

Safety Story

A passing build should validate that this code was not used anywhere.

Labels and Review

• Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
• Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[coderabbitai]

📝 Walkthrough

Walkthrough

This change removes the ConnectResultsListFragment class and its associated navigation infrastructure from the application. Specifically, the navigation action connecting connect_job_delivery_progress_fragment to connect_results_fragment is deleted from the navigation graph, along with the fragment's definition and its showPayments boolean argument. The ConnectResultsListFragment Java class—which displayed deliveries or payments via a RecyclerView-based UI with verification and payment view holders—is entirely deleted.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10–15 minutes

• Verify that no other fragments, activities, or code paths reference ConnectResultsListFragment or the deleted navigation action
• Confirm that the removal does not break any downstream features that may depend on displaying connect results
• Review the navigation graph changes to ensure consistency with the overall app flow

Possibly related PRs

• Pm phase4 coderabbit #3200: Modifies/refactors ConnectResultsListFragment with view binding and adapter changes, operating directly on the same class being deleted here
• Created base waiting loader and implemented in multiple connect screens #3378: Refactors ConnectResultsListFragment to adopt BaseFragment/view-binding pattern, directly overlapping with the deleted fragment
• Require active job in some places #3198: Refactors ConnectResultsListFragment to extend ConnectJobFragment and updates its adapter, directly related to the removed class

Suggested reviewers

• Jignesh-dimagi
• OrangeAndGreen
• conroy-ricketts

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing an unused results list screen from the codebase.
Description check	✅ Passed	The description covers Product Description and Safety Story sections adequately, though Technical Summary and QA Plan sections are missing or incomplete.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch deleteUnusedResultsList

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5338ee9 and 548cd19.

📒 Files selected for processing (2)

• app/res/navigation/nav_graph_connect.xml (0 hunks)
• app/src/org/commcare/fragments/connect/ConnectResultsListFragment.java (0 hunks)

💤 Files with no reviewable changes (2)

• app/src/org/commcare/fragments/connect/ConnectResultsListFragment.java
• app/res/navigation/nav_graph_connect.xml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Lint Code Base

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}