Emit widget changed event on manual ComboboxWidget item deletion

[avazirna]

Product Description

Copy of #3441

[coderabbitai]

📝 Walkthrough

Walkthrough

ComboboxWidget.java was updated to remove four unused Android imports (TargetApi, Build, View, AdapterView) and to modify the TextWatcher's afterTextChanged method by replacing a call to clearWarningMessage() with a call to widgetEntryChanged(). These changes involve code cleanup and a behavioral modification in the text-change handler.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Primary focus: Verify that replacing clearWarningMessage() with widgetEntryChanged() maintains the intended behavior and does not introduce unintended side effects in the text change handler.
• Note: The unused import removal is straightforward; however, the method call replacement requires understanding the semantics and side effects of both methods to ensure functional correctness.

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description is incomplete, providing only a reference to another PR without detailing the rationale, safety assurance, test coverage, or QA plans required by the template.	Expand the description to include Technical Summary with rationale, Safety Assurance with testing details, test coverage information, and QA plans as required by the template.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: replacing clearWarningMessage() with widgetEntryChanged() to emit a widget changed event when text is manually changed in ComboboxWidget.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch emit-data-changed-on-comboboxwidget-item-delete-hotfix

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b18424c and 085afa1.

📒 Files selected for processing (1)

• app/src/org/commcare/views/widgets/ComboboxWidget.java (1 hunks)

🔇 Additional comments (1)

app/src/org/commcare/views/widgets/ComboboxWidget.java (1)

87-100: Good fix—ensures data change notifications are emitted on all text modifications, including deletions.

The change from clearWarningMessage() to widgetEntryChanged() correctly addresses the PR objective. Verification confirms that widgetEntryChanged() (defined in the parent class QuestionWidget) internally calls clearWarningMessage() at line 722, so the warning-clearing functionality is preserved. Additionally, widgetEntryChanged() notifies listeners of the change, which is the desired behavior for detecting deletions via backspace. This aligns consistently with the other listeners at lines 73 (item click) and 83 (focus loss).

The performance concern is not an issue: widgetEntryChanged() performs only lightweight operations (null checks, view visibility toggles, and listener notification), making it safe to call on every keystroke via afterTextChanged().

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}