Emit widget changed event on manual ComboboxWidget item deletion

[avazirna]

Product Description

Copy of #3441

[coderabbitai]

Caution

Review failed

Failed to post review comments

📝 Walkthrough

Walkthrough

This PR comprises multiple coordinated changes across the CommCare Android application: a Google Play Services Maps dependency version bump (19.0.0 → 19.2.0), navigation drawer UI refinements with responsive padding dimensions, LoginActivity enhancements to set presetAppId earlier during app selection, PersonalID session data augmentation with OTP attempt tracking, expanded error code enumeration and corresponding error-handling logic in the PersonalID API layer, refactored OTP manager setup with centralized instantiation and analytics event reporting in the phone verification fragment, and minor adjustments to analytics utilities and the ComboboxWidget text-change handler.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Areas requiring extra attention:

• app/src/org/commcare/connect/network/base/BaseApiHandler.kt — Enum expansion with 23 new error constants and updated shouldAllowRetry() logic; verify all error mappings are correct and retry conditions are intentional.
• app/src/org/commcare/connect/network/connectId/PersonalIdApiHandler.java — Extensive refactoring with new multi-case error handling, parser integrations, and API call site updates; ensure error code delegation to handleErrorCodeIfPresent and session data updates align across all PersonalID actions.
• app/src/org/commcare/fragments/personalId/PersonalIdPhoneVerificationFragment.java — Centralized setupOtpManager() method and OTP attempt tracking with analytics integration; verify OTP fallback logic and auto-switch behavior are correctly gated.
• app/src/org/commcare/android/database/connect/models/PersonalIdSessionData.kt — Public API addition of otpAttempts field; confirm serialization/deserialization and all usage sites handle the new field correctly.

Possibly related PRs

• Updated Maps SDK to 19.2.0 #3429 — Both modify app/build.gradle to bump com.google.android.gms:play-services-maps from 19.0.0 to 19.2.0 (identical dependency update).
• Login: App switching fix #3417 — Both modify LoginActivity to set presetAppId earlier in the app selection flow (direct code-level overlap).
• Set side nav padding and margin top in percentage #3434 — Both modify navigation drawer UI and dimension resources; main PR adds new dimension constants and padding/margin application, while the related PR refines sign-out section positioning (overlapping UI changes).

Suggested labels

skip-integration-tests

Suggested reviewers

• Jignesh-dimagi
• shubham1g5
• OrangeAndGreen

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is largely incomplete. It references an external PR but lacks required sections: Product Description (actual user-facing effects), Technical Summary (rationale/design decisions), Safety Assurance (testing and QA plans), and other critical sections from the template.	Complete the description by filling out all required template sections including Product Description, Technical Summary, Safety story, test coverage details, and QA Plan with specific testing strategies and ticket references.
Docstring Coverage	⚠️ Warning	Docstring coverage is 4.76% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the primary change: emitting a widget changed event on manual ComboboxWidget item deletion, which matches the ComboboxWidget.java changes in the diff.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch hotfix-emit-data-changed-on-comboboxwidget-item-delete

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}