Skip to content

Added analytics event for PersonalID account lockout (on Backup Code … #3371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OrangeAndGreen merged 1 commit into from
Oct 17, 2025
Merged

Added analytics event for PersonalID account lockout (on Backup Code … #3371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/src/org/commcare/fragments/personalId/PersonalIdBackupCodeFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ private void handleFailedBackupCodeAttempt() {

private void handleAccountLockout() {
logRecoveryResult(false);
FirebaseAnalyticsUtil.reportPersonalIdConfigurationFailure(AnalyticsParamValue.START_CONFIGURATION_LOCKED_ACCOUNT_FAILURE);
Copy link
Contributor

@shubham1g5 shubham1g5 Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OrangeAndGreen I see this is also being logged by handleCommonSignupFailures ? and I am confused what path is the right one that gets triggered on locked account ?

Copy link
Contributor Author

@OrangeAndGreen OrangeAndGreen Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we still have plans to clean this up but in the meantime it gets caught in two ways. One is the case in this fragment where the API call to verify backup code succeeds whether correct/incorrect/locked, but the session is updated to indicate which is the case (via dbKey, sessionFailureCode, and attemptsLeft).
In any other API call the server can also fail and return a code indicating that the account is locked, which we handle with a common error handler. In practice I think that failure only ever happens on the confirm_otp call, although it could be on other calls later in the workflow as well.

clearBackupCodeFields();
navigateWithMessage(getString(R.string.personalid_recovery_lockout_title),
getString(R.string.personalid_recovery_lockout_message),
Expand Down