Skip to content

Log exceptions when stop tracing #3367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avazirna merged 1 commit into from
Oct 15, 2025
Merged

Log exceptions when stop tracing #3367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/src/org/commcare/adapters/EntityStringFilterer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ protected void filter() {
String.valueOf(StringUtils.getSumOfLengths(searchTerms)));
attrs.put(CCPerfMonitoring.ATTR_NUM_CASES_LOADED, String.valueOf(fullEntityList.size()));
CCPerfMonitoring.INSTANCE.stopTracing(trace, attrs);
} catch (Exception ignored) {}
} catch (Exception e) {
Logger.exception("Failed to stop tracing ", e);
}
}

long time = System.currentTimeMillis() - startTime;
Expand Down
8 changes: 6 additions & 2 deletions app/src/org/commcare/tasks/DataPullTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,9 @@ private ResultAndError<PullTaskResult> getRequestResultOrRetry(AndroidTransactio
attrs.put(CCPerfMonitoring.ATTR_SYNC_SUCESS,
PullTaskResult.DOWNLOAD_SUCCESS.equals(result.data) ? PrefValues.YES : PrefValues.NO);
CCPerfMonitoring.INSTANCE.stopTracing(trace, attrs);
} catch (Exception ignored) {}
} catch (Exception e) {
Logger.exception("Failed to stop tracing ", e);
}
}

if (PullTaskResult.RETRY_NEEDED.equals(result.data)) {
Expand Down Expand Up @@ -330,7 +332,9 @@ private ResultAndError<PullTaskResult> getRequestResultOrRetry(AndroidTransactio
AnalyticsParamValue.SYNC_TRIGGER_USER : AnalyticsParamValue.SYNC_TRIGGER_AUTO);
attrs.put(CCPerfMonitoring.ATTR_SYNC_SUCESS, PrefValues.NO);
CCPerfMonitoring.INSTANCE.stopTracing(trace, attrs);
} catch (Exception ignored) {}
} catch (Exception e) {
Logger.exception("Failed to stop tracing ", e);
}

wipeLoginIfItOccurred();
this.publishProgress(PROGRESS_DONE);
Expand Down
4 changes: 3 additions & 1 deletion app/src/org/commcare/tasks/EntityLoaderTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ protected Pair<List<Entity<TreeReference>>, List<TreeReference>> doInBackground(
attrs.put(CCPerfMonitoring.ATTR_NUM_CASES_LOADED,
String.valueOf((entities == null || entities.first == null ? 0 : entities.first.size())));
CCPerfMonitoring.INSTANCE.stopTracing(trace, attrs);
} catch (Exception ignored) {}
} catch (Exception e) {
Logger.exception("Failed to stop tracing ", e);
}
}
return entities;
} catch (XPathException xe) {
Expand Down
4 changes: 3 additions & 1 deletion app/src/org/commcare/tasks/FormLoaderTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,9 @@ protected FECWrapper doTaskBackground(Integer... formDefId) {
attrs.put(CCPerfMonitoring.ATTR_FORM_NAME, fd.getName());
attrs.put(CCPerfMonitoring.ATTR_FORM_XMLNS, fd.getMainInstance().schema);
CCPerfMonitoring.INSTANCE.stopTracing(trace, attrs);
} catch (Exception ignored) {}
} catch (Exception e) {
Logger.exception("Failed to stop tracing ", e);
}
return data;
}

Expand Down