Remove messaging from app bar

[shubham1g5]

Product Description

https://dimagi.atlassian.net/browse/CCCT-1801

Labels and Review

• Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
• Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[coderabbitai]

📝 Walkthrough

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description only includes a product ticket link and a labels checklist and omits several required sections from the repository template such as the Technical Summary with design rationale and ticket reference, Feature Flag details, and the Safety Assurance sections including safety story, automated test coverage, and QA Plan, and it also lacks the actual Release Note and QA Note content.	Please expand the description to follow the repository template by adding a Technical Summary that explains the rationale for removing the messaging feature and links the corresponding ticket, include any Feature Flag implications, fully detail the Safety Assurance sections with a safety story, automated test coverage, and QA Plan, and provide the actual Release Note and QA Note text instead of only checklist placeholders.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly and accurately describes the primary change—removing the messaging feature from the app bar—directly reflecting the menu XML and activity code modifications in this pull request.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch removeMessagingFromAppBar

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b9a85f7 and 038f448.

📒 Files selected for processing (2)

• app/res/menu/menu_connect.xml (0 hunks)
• app/src/org/commcare/activities/connect/ConnectActivity.java (0 hunks)

💤 Files with no reviewable changes (2)

• app/src/org/commcare/activities/connect/ConnectActivity.java
• app/res/menu/menu_connect.xml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Lint Code Base

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Jignesh-dimagi]

Should be good to remove retrieveMessages also? I think app must be syncing for current messages in drawer activity to update the icon status?

[shubham1g5]

Semms like app doesn't sync in drawer today but just shows the icon status based on the local db, so think we still need to have it here for the moment (we should replace this with a background worker task in future)

[Jignesh-dimagi]

Ticket says to update the documentation also, not sure if its already done or not required, so just putting it here.

[shubham1g5]

Ticket says to update the documentation also, not sure if its already done or not required, so just putting it here.

Yes, I added that but could not find any docs that need to be updated for this change.