Skip to content

Solved navigation to PersonalIdMessageFragment crash #3341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaypanchal-13 wants to merge 3 commits into from
Closed

Solved navigation to PersonalIdMessageFragment crash #3341

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ea00e8
Solved navigation to PersonalIdMessageFragment crash
jaypanchal-13 Sep 12, 2025
7fd6c0f
Merge branch 'master' into CCCT-1691-crash-on-navigateToMessageDisplay
jaypanchal-13 Sep 17, 2025
f315ed3
Merge branch 'master' into CCCT-1691-crash-on-navigateToMessageDisplay
jaypanchal-13 Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/src/org/commcare/fragments/personalId/PersonalIdBiometricConfigFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import androidx.biometric.BiometricManager;
import androidx.biometric.BiometricPrompt;
import androidx.lifecycle.ViewModelProvider;
import androidx.navigation.NavController;
import androidx.navigation.NavDirections;
import androidx.navigation.Navigation;

Expand Down Expand Up @@ -353,6 +354,12 @@ protected void navigateToMessageDisplay(@NotNull String title, @Nullable String
int phase, int buttonText) {
NavDirections navDirections = PersonalIdBiometricConfigFragmentDirections.actionPersonalidBiometricConfigToPersonalidMessage(
title, message, phase, getString(buttonText), null).setIsCancellable(isCancellable);
Navigation.findNavController(binding.getRoot()).navigate(navDirections);

NavController navController = Navigation.findNavController(binding.getRoot());

// Only navigate if we’re not already on PersonalIdMessageFragment
if (navController.getCurrentDestination() != null && navController.getCurrentDestination().getId() != R.id.personalid_message_display) {
navController.navigate(navDirections);
}
}
}
Loading