-
-
Notifications
You must be signed in to change notification settings - Fork 45
Bumps gradle, Kotlin and makes relevant changes #3338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughUpdates Gradle tooling and modernizes Android build configuration. The Android Gradle Plugin is bumped from 8.6.1 to 8.13.0 and the Gradle wrapper from 8.7 to 8.13. In app/build.gradle, deprecated Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Pre-merge checks (2 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
app/build.gradle (2)
506-509: lintOptions → lint migration is fine; consider scoping disables or moving to lint.xml.Keeping MissingTranslation/ResourceType disabled globally can hide regressions. If feasible, move these to a lint.xml baseline or scope per variant/task.
247-251: Packaging excludes DSL is fine; optional: rename topackagingpackagingOptions.resources.excludes is the correct API for excluding Java resource paths (works on AGP 7+). (developer.android.com)
Note: thepackagingOptionsproperty was renamed topackagingin newer AGP releases — consider switching toandroid { packaging { resources { ... } } }to avoid deprecation warnings. (developer.android.com)Verified only occurrence in app/build.gradle — lines 247–249 (rg output).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
app/build.gradle(2 hunks)build.gradle(1 hunks)gradle/wrapper/gradle-wrapper.properties(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Lint Code Base
🔇 Additional comments (2)
gradle/wrapper/gradle-wrapper.properties (1)
4-4: Add distributionSha256Sum and commit regenerated wrapper artifactsAdd distributionSha256Sum to gradle/wrapper/gradle-wrapper.properties to pin the Gradle 8.13 download. Confirm gradle/wrapper/gradle-wrapper.jar and gradlew(.bat) were regenerated and included in the commit — current verification output only showed the distributionUrl line.
distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-bin.zip +distributionSha256Sum=<paste official sha256>Quick checks:
rg -n "distributionUrl" gradle/wrapper/gradle-wrapper.properties git diff --name-only origin/main...HEAD | rg -n 'gradle/wrapper/gradle-wrapper\.jar|gradlew(\.bat)?'app/build.gradle (1)
503-505: Correct replacement for deprecated aaptOptions → androidResources.ignoreAssetsPattern.Syntax and placement under android { } look right.
62facb3 to
d82f234
Compare
|
@damagatchi retest this please |
1 similar comment
|
@damagatchi retest this please |
a2a7d14 to
0a20e1a
Compare
|
@damagatchi retest this please |
37de81a to
376fa67
Compare
…d errors related to export not defined
376fa67 to
9e8d0ac
Compare
|
@damagatchi retest this please |
| @@ -0,0 +1,24 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubham1g5 Just trying to understand how does bumping the kotlin and gradle version needs this changes? If its required, can you please add more details or link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is not a directly documentation or change log on this from AGP but my sense is this change in 8.12 changes how Android deals with generating test manifests and is a consequence of that we need to overide any manifests properties from underlying libraries we are using both in our test and main manifest to have the tests passing.
Gradle and Kotlin update
Labels and Review