-
-
Notifications
You must be signed in to change notification settings - Fork 45
Analytics for user funneling #3328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
6a42266
Analytics for user funneling
jaypanchal-13 8ec5dc2
Removed yellow cross icon from earned credential screen
jaypanchal-13 7ae4200
Merge branch 'master' into CCCT-1671-analytic-user-funneling
jaypanchal-13 74e8ac2
Merge branch 'master' into CCCT-1671-analytic-user-funneling
jaypanchal-13 4a40b49
Revert "Removed yellow cross icon from earned credential screen"
jaypanchal-13 4eb7a9f
Merge remote-tracking branch 'origin/CCCT-1671-analytic-user-funnelin…
jaypanchal-13 c127d9b
Merge branch 'master' into CCCT-1671-analytic-user-funneling
jaypanchal-13 006f443
Address comments
jaypanchal-13 51cef50
Merge branch 'master' into CCCT-1671-analytic-user-funneling
jaypanchal-13 64e76c6
Changed analytics values as per comments
jaypanchal-13 ada6865
Merge branch 'master' into CCCT-1671-analytic-user-funneling
jaypanchal-13 fb48892
Merge branch 'master' into CCCT-1671-analytic-user-funneling
jaypanchal-13 f3628e0
Merge remote-tracking branch 'origin/master' into CCCT-1671-analytic-…
jaypanchal-13 21bf164
Addressed changes
jaypanchal-13 3e4d144
Merge remote-tracking branch 'refs/remotes/origin/master' into CCCT-1…
jaypanchal-13 d4250aa
Addressed commit changes
jaypanchal-13 63c4203
Merge branch 'master' into CCCT-1671-analytic-user-funneling
jaypanchal-13 0b049ab
Merge branch 'master' into CCCT-1671-analytic-user-funneling
jaypanchal-13 5be9197
Merge branch 'master' into CCCT-1671-analytic-user-funneling
jaypanchal-13 ea88ca1
Merge remote-tracking branch 'origin/master' into CCCT-1671-analytic-…
jaypanchal-13 3969379
comments addressed
jaypanchal-13 3b4c7bf
Merge branch 'master' into CCCT-1671-analytic-user-funneling
jaypanchal-13 9d208e6
Merge remote-tracking branch 'origin/master' into CCCT-1671-analytic-…
jaypanchal-13 6e006af
used 'this'
jaypanchal-13 7702356
Merge remote-tracking branch 'origin/CCCT-1671-analytic-user-funnelin…
jaypanchal-13 3f9ff60
Merge branch 'master' into CCCT-1671-analytic-user-funneling
jaypanchal-13 f8c0306
minor changes
jaypanchal-13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OrangeAndGreen can you confirm this logic ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed, that's consistent with the logic that we use on the delivery progress page for total progress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaypanchal-13 seems like we are maintaining this same logic in 2 places, can we also use this method from the other place Dave linked to maintain consistency of logic.