- implement the nav drawer based on Controller #3287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham1g5
reviewed
Aug 7, 2025
| startAllowed = savedInstanceState.getBoolean("startAllowed"); | ||
| } | ||
|
|
||
| private void setupDrawerController() { |
Contributor
There was a problem hiding this comment.
think we should still have a base activity that can contain this method along with the logic in onOptionsItemSelected
shubham1g5
requested changes
Aug 7, 2025
Contributor
shubham1g5
left a comment
shubham1g5
left a comment
There was a problem hiding this comment.
changes for the correponding landscape layouts (layout-land) are missing.
shubham1g5
requested changes
Aug 7, 2025
Comment on lines
1001
to
1022
| protected void setupDrawerController() { | ||
| PersonalIdManager personalIdManager = PersonalIdManager.getInstance(); | ||
| personalIdManager.init(this); | ||
| if (personalIdManager.isloggedIn()) { | ||
| View rootView = findViewById(android.R.id.content); | ||
| DrawerViewRefs drawerRefs = new DrawerViewRefs(rootView); | ||
| drawerController = new BaseDrawerController( | ||
| this, | ||
| drawerRefs, | ||
| new Function2<BaseDrawerController.NavItemType, String, Unit>() { | ||
| @Override | ||
| public Unit invoke(BaseDrawerController.NavItemType navItemType, String recordId) { | ||
| handleDrawerItemClick(navItemType, recordId); | ||
| return Unit.INSTANCE; | ||
| } | ||
| } | ||
| ); | ||
| drawerController.setupDrawer(); | ||
| } | ||
| } | ||
|
|
||
| protected void handleDrawerItemClick(BaseDrawerController.NavItemType navItemType, String recordId){} |
Contributor
There was a problem hiding this comment.
can we add this instead in a BaseDrawerActivity ? I don't really want us to bulk the code in CommCareActivity without a good reason.
| case COMMCARE_APPS: | ||
| protected void handleDrawerItemClick(BaseDrawerController.NavItemType itemType, String recordId) { | ||
| switch (itemType) { | ||
| case OPPORTUNITIES -> { /* handle */ } |
Contributor
There was a problem hiding this comment.
can we also add the click handling now that the connect code is merged.
shubham1g5
requested changes
Aug 8, 2025
| } | ||
|
|
||
|
|
||
| protected void handleDrawerItemClick(BaseDrawerController.NavItemType navItemType, String recordId){} |
Contributor
There was a problem hiding this comment.
we should move this to BaseDrawerActivity as well.
| } | ||
| loadIntentAndInstanceState(savedInstanceState); | ||
| persistCommCareAppState(); | ||
| setupDrawerController(); |
Contributor
There was a problem hiding this comment.
can this be called in onCreate or onPostCreate of BaseDrawerActivity` as well ?
| import androidx.recyclerview.widget.RecyclerView | ||
| import org.commcare.dalvik.R | ||
|
|
||
| class DrawerViewRefs(rootView: View) { |
…nto pm_nav_design_change # Conflicts: # app/res/values-lt/strings.xml # app/res/values-no/strings.xml # app/src/org/commcare/activities/StandardHomeActivity.java
…roid into pm_nav_design_change # Conflicts: # app/res/values-no/strings.xml
shubham1g5
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Made changes for the BaseDrawer activity to BaseDrawerController so that there will no need of extending the activity we can directly plugin that in the calling activity
Technical Summary
Feature Flag
Safety Assurance
Safety story
Automated test coverage
QA Plan
Labels and Review