Skip to content

Resolved crashes as per firebase crashlytics #3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaypanchal-13 wants to merge 2 commits into from
Closed

Resolved crashes as per firebase crashlytics #3277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91146f4
Resolved crashes as per firebase crashlytics
jaypanchal-13 Jul 30, 2025
418a557
Merge branch 'feature/connect' into firebase-crashes
jaypanchal-13 Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/src/org/commcare/activities/StandardHomeActivityUIController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,9 @@ public void refreshView() {
}

public void updateConnectProgress() {
if (viewJobCard == null) {
return;
}
Comment on lines +179 to +181
Copy link
Contributor

@Jignesh-dimagi Jignesh-dimagi Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if instantiate here and show the job card details?

Copy link
Contributor Author

@jaypanchal-13 jaypanchal-13 Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intialized it here

RecyclerView recyclerView = viewJobCard.findViewById(R.id.rdDeliveryTypeList);
ConnectJobRecord job = ConnectJobHelper.INSTANCE.getActiveJob();

Expand Down
18 changes: 9 additions & 9 deletions app/src/org/commcare/activities/connect/ConnectActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,15 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {

if (getIntent().getBooleanExtra("info", false)) {
ConnectJobRecord job = ConnectJobHelper.INSTANCE.getActiveJob();
Objects.requireNonNull(job);

startDestinationId = job.getStatus() == ConnectJobRecord.STATUS_DELIVERING
? R.id.connect_job_delivery_progress_fragment
: R.id.connect_job_learning_progress_fragment;

boolean buttons = getIntent().getBooleanExtra("buttons", true);
startArgs = new Bundle();
startArgs.putBoolean("showLaunch", buttons);
if (job != null) {
startDestinationId = job.getStatus() == ConnectJobRecord.STATUS_DELIVERING
? R.id.connect_job_delivery_progress_fragment
: R.id.connect_job_learning_progress_fragment;

boolean buttons = getIntent().getBooleanExtra("buttons", true);
startArgs = new Bundle();
startArgs.putBoolean("showLaunch", buttons);
}
Comment on lines -84 to +92
Copy link
Contributor

@Jignesh-dimagi Jignesh-dimagi Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes should not be part of this PR


} else if (!Strings.isNullOrEmpty(redirectionAction)) {
Logger.log("ConnectActivity", "Redirecting to unlock fragment");
Expand Down
3 changes: 3 additions & 0 deletions app/src/org/commcare/connect/network/ConnectNetworkHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,9 @@ public static void showOutdatedApiError(Context context) {
}

public static void handleTokenUnavailableException(Context context) {
if (context == null) {
return;
}
Comment on lines +433 to +435
Copy link
Contributor

@Jignesh-dimagi Jignesh-dimagi Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, please remove for this PR.

Toast.makeText(context, context.getString(R.string.recovery_network_token_unavailable),
Toast.LENGTH_LONG).show();
}
Expand Down