Pm qa 7928 fix

[pm-dimagi]

Product Description

https://dimagi.atlassian.net/browse/QA-7928
Fixed this, it was updating the tile 2nd time before the api response

Technical Summary

Feature Flag

Safety Assurance

Safety story

Automated test coverage

QA Plan

Labels and Review

• Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
• Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[Jignesh-dimagi]

@pm-dimagi How does this solve this issue? Previously, without these changes, also update payment confirmation should be successful only.

[coderabbitai]

Caution

Review failed

Failed to post review comments.

📝 Walkthrough

Walkthrough

This pull request introduces a comprehensive set of features and refactors centered on the CommCare Connect module, focusing on messaging, job management, and delivery/payment workflows. Major changes include the addition of new activities (ConnectActivity, ConnectMessagingActivity), multiple new fragments for Connect jobs, messaging, and delivery progress, and several new RecyclerView adapters for displaying job lists, messages, and delivery/payment summaries. The manifest is updated to declare new components, and new resources (layouts, drawables, strings) are added or modified to support the Connect UI. Core logic for Connect jobs, messaging, and navigation is encapsulated in new helper classes and Kotlin objects. The notification system is extended to handle Connect-specific push notifications with custom actions and broadcast receivers. Analytics integration is enhanced with new user property reporting. Several classes are refactored for exception handling, code organization, and removal of deprecated or redundant logic. The update also introduces or modifies database helpers for Connect job, user, and messaging data management, and updates Proguard rules to support new serialization libraries.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ConnectActivity
    participant ConnectJobHelper
    participant MessageManager
    participant ConnectMessagingActivity
    participant ConnectDatabaseHelper
    participant FirebaseMessagingService
    participant NotificationManager

    %% Connect job navigation and progress update
    User->>ConnectActivity: Launch Connect feature
    ConnectActivity->>ConnectJobHelper: Set active job, update progress
    ConnectJobHelper->>ConnectDatabaseHelper: Fetch/update job data
    ConnectActivity->>User: Show job list/progress UI

    %% Messaging workflow
    User->>ConnectMessagingActivity: Open messaging (via menu or notification)
    ConnectMessagingActivity->>ConnectDatabaseHelper: Retrieve channels/messages
    ConnectMessagingActivity->>MessageManager: Retrieve new messages
    MessageManager->>ConnectDatabaseHelper: Store new messages
    ConnectMessagingActivity->>User: Display updated messages

    %% Push notification handling
    FirebaseMessagingService->>NotificationManager: Receive FCM push
    NotificationManager->>FirebaseMessagingUtil: Handle notification
    FirebaseMessagingUtil->>ConnectActivity/ConnectMessagingActivity: Launch activity or update UI
    FirebaseMessagingUtil->>MessageManager: Update local data if needed

    %% Payment acknowledgment via broadcast
    NotificationManager->>PaymentAcknowledgeReceiver: Send payment acknowledgment intent
    PaymentAcknowledgeReceiver->>ConnectJobHelper: Update payment confirmation
    ConnectJobHelper->>ConnectDatabaseHelper: Update payment record
    PaymentAcknowledgeReceiver->>User: (No direct UI, silent update)

Loading

Estimated code review effort

5 (>120 minutes)

Possibly related PRs

• Fixed logic around receiving and storing Connect DB passphrases. #3033: Both PRs modify the handleReceivedDbPassphrase method in ConnectDatabaseHelper.java to fix and improve logic around rekeying the database and storing the local passphrase.
• Reviewed: Messaging section #3065: Both PRs add or refine Connect messaging activities, fragments, adapters, and database helpers, directly overlapping in messaging feature implementation.
• CCCT-485 || Connect Messaging Implementation Part-1 #2870: Both PRs introduce the ConnectMessagingActivity and related messaging UI components and helpers, indicating direct code-level overlap in messaging feature development.

Suggested labels

skip-integration-tests

Suggested reviewers

• shubham1g5

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch pm_qa_7928_fix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pm-dimagi]

@pm-dimagi How does this solve this issue? Previously, without these changes, also update payment confirmation should be successful only.

Yes Jignesh payment is successful only ... but the issue is updatePaymentConfirmationTile() was calling before the api result so it was showing the dialog again because payment is not marked confirmed