Play store service check #3258
Merged
Play store service check #3258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jignesh-dimagi
requested changes
Jul 18, 2025
| Dialog dialog = googleApiAvailability.getErrorDialog(this, status, PLAY_SERVICES_RESOLUTION_REQUEST, | ||
| dialog1 -> { | ||
| onConfigurationFailure(playServiceError, | ||
| "Google Play Services are required. Please update/install them."); |
| if (dialog != null) { | ||
| dialog.show(); | ||
| } else { | ||
| onConfigurationFailure(googleApiAvailability.getErrorString(status), |
| private void checkGooglePlayServices() { | ||
| GoogleApiAvailability googleApiAvailability = GoogleApiAvailability.getInstance(); | ||
| int status = googleApiAvailability.isGooglePlayServicesAvailable(requireActivity()); | ||
| if (status != ConnectionResult.SUCCESS) { |
Contributor
There was a problem hiding this comment.
@pm-dimagi I am also seeing some concept of googleApiAvailability.isUserResolvableError(resultCode) and then showing the dialog error with requestCode.
shubham1g5
requested changes
Jul 18, 2025
| Logger.log(LogTypes.TYPE_MAINTENANCE,"Google Play Services issue:" + playServiceError); | ||
| Dialog dialog = googleApiAvailability.getErrorDialog(this, status, PLAY_SERVICES_RESOLUTION_REQUEST, | ||
| dialog1 -> { | ||
| onConfigurationFailure(playServiceError, |
Contributor
There was a problem hiding this comment.
instead of string error, pass play_services_$status as the failure code here and below.
| if (status != ConnectionResult.SUCCESS) { | ||
| String playServiceError = googleApiAvailability.getErrorString(status); | ||
| Logger.log(LogTypes.TYPE_MAINTENANCE,"Google Play Services issue:" + playServiceError); | ||
| Dialog dialog = googleApiAvailability.getErrorDialog(this, status, PLAY_SERVICES_RESOLUTION_REQUEST, |
shubham1g5
requested changes
Jul 18, 2025
app/res/values/strings.xml
Outdated
|
|
||
| <string name="my_credentials">My Credentials</string> | ||
| <string name="credential">Credential</string> | ||
| <string name="play_service_update_error">Google Play Services are required. Please update/install them.</string> |
Contributor
There was a problem hiding this comment.
think we can have one general message here - Please make sure Google Play services is supported on the device and is up to date instead of two.
We should also add translations in all languages here.
app/src/org/commcare/fragments/personalId/PersonalIdPhoneFragment.java
Outdated
Show resolved
Hide resolved
app/src/org/commcare/fragments/personalId/PersonalIdPhoneFragment.java
Outdated
Show resolved
Hide resolved
app/src/org/commcare/fragments/personalId/PersonalIdPhoneFragment.java
Outdated
Show resolved
Hide resolved
shubham1g5
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
This is to check if the play store is not updated or missing
Reference doc is here:https://developers.google.com/android/reference/com/google/android/gms/common/GoogleApiAvailability?utm_source=chatgpt.com
Not able to test this as 2 of my device is updated with the service
Technical Summary
Feature Flag
Safety Assurance
Safety story
Automated test coverage
QA Plan
Labels and Review