Corrected the app crash after downloading the learning/delivery app

[Jignesh-dimagi]

Technical Summary

https://dimagi.atlassian.net/browse/QA-7932

Problem statement:
When app validation was getting succeeded, code was removing the top fragment by calling popBackStack so fragment below in stack i.e. job list fragment was getting activated and start calling API, which was causing crash when trying to access the UI after API success as whole activity was finished before that only.

Solution:
Directly finish the activity from the current fragment only, without pop backing the fragment in stack.

QA Plan

App shouldn't crash after downloading learn/delivery app

Labels and Review

• Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
• Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[shubham1g5]

@Jignesh-dimagi it would be good to add more details in Technical Description section of the PR template on the root cause of the issue as well.

[Jignesh-dimagi]

@Jignesh-dimagi it would be good to add more details in Technical Description section of the PR template on the root cause of the issue as well.

@shubham1g5 When app validation was getting succeeded, code was removing the top fragment by calling popBackStack so fragment below in stack i.e. job list fragment was getting activated and start calling API, which was causing crash when trying to access the UI after API success as whole activity was finished before that only.

Solution: Directly finish the activity from the current fragment only, without pop backing the fragment in stack.

[shubham1g5]

Thanks! That makes sense to me, but more generally we should be providing this info in Technical Description of PR descriptions itself to help anyone looking at the PR to get enough context on why the particular change was made.

[Jignesh-dimagi]

Thanks! That makes sense to me, but more generally we should be providing this info in Technical Description of PR descriptions itself to help anyone looking at the PR to get enough context on why the particular change was made.

Added in description also