Skip to content

Conversation

@pm-dimagi
Copy link
Contributor

Product Description

QA-7927
Fix-> put the visibility condition
https://dimagi.atlassian.net/browse/QA-7929
Fix-> there was no code for this put the appropiate code
QA-7921
Fix_ called sync code which was not present earlier
QA-7926
Fix-> There was a return statement in if else condition removed that in updateButtons function

Technical Summary

Feature Flag

Safety Assurance

Safety story

Automated test coverage

QA Plan

Labels and Review

  • Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
  • Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@pm-dimagi pm-dimagi requested a review from shubham1g5 July 18, 2025 10:06
Comment on lines +253 to +256
private void navigateToJobDetailBottomSheet(View view) {
Navigation.findNavController(view).navigate(
ConnectLearningProgressFragmentDirections.actionConnectJobLearningProgressFragmentToConnectJobDetailBottomSheetDialogFragment());
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make sure to format this, seems a bit weird here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its formatted tried

@pm-dimagi pm-dimagi merged commit e9f4b18 into Beta_2.58_474459 Jul 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants