-
-
Notifications
You must be signed in to change notification settings - Fork 45
Passed location to start configuration call #3201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a5d371e
- passed location to make configuration call
pm-dimagi 829a449
- fixed code rabbit reviews
pm-dimagi 4a69803
-update continue button state after location capture
pm-dimagi 375ea98
-fixed double permission issue, and location service negative case
pm-dimagi 1a5d890
- fixed buttonText, and handle dialog
pm-dimagi a40af3e
- abstract code for location failure , removed unecesary null check
pm-dimagi 36e6699
- removed unused function
pm-dimagi 703c3cf
-fixed calling method from wrong place, removed extra if condition , …
pm-dimagi 672149c
Merge branch 'master' of https://github.com/dimagi/commcare-android i…
pm-dimagi 0d59476
-resolved conflicts with reabase master
pm-dimagi ecef453
-removed unused onactivity result
pm-dimagi 058b5ed
- remove e.printstacktrace
pm-dimagi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
app/src/org/commcare/location/LocationRequestFailureHandler.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package org.commcare.location | ||
| import com.google.android.gms.common.api.ResolvableApiException | ||
|
|
||
| object LocationRequestFailureHandler { | ||
|
|
||
| interface LocationResolutionCallback { | ||
| fun onResolvableException(exception: ResolvableApiException) | ||
| fun onNonResolvableFailure() | ||
| } | ||
|
|
||
| fun handleFailure( | ||
| failure: CommCareLocationListener.Failure, | ||
| callback: LocationResolutionCallback | ||
| ) { | ||
| when (failure) { | ||
| is CommCareLocationListener.Failure.ApiException -> { | ||
| val exception = failure.exception | ||
| if (exception is ResolvableApiException) { | ||
| callback.onResolvableException(exception) | ||
shubham1g5 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } else { | ||
| callback.onNonResolvableFailure() | ||
| } | ||
| } | ||
| else -> callback.onNonResolvableFailure() | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.