Backup code error when not matching criteria #3164

Jignesh-dimagi · 2025-06-06T11:24:10Z

Technical Summary

https://dimagi.atlassian.net/browse/QA-7824

Labels and Review

Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
Risk label is set correctly
The set of people pinged as reviewers is appropriate for the level of risk of the change

coderabbitai · 2025-06-06T11:25:37Z

📝 Walkthrough

Walkthrough

The update modifies the validateBackupCodeInputs() method in the PersonalIdBackupCodeFragment.java file. It introduces logic to set the visibility of the error message view (connectBackupCodeErrorMessage) based on the validity and presence of the backup code input. The error message is shown only when the first backup code input is not empty and the input is invalid; otherwise, it is hidden. This adjustment is performed before updating the error text and the state of the continue button.

Possibly related PRs

Workflow Fixes #3146: Modifies UI visibility settings in configureUiByMode() within the same fragment, focusing on different UI behaviors but in the same area of the codebase.

Suggested reviewers

OrangeAndGreen
pm-dimagi
shubham1g5

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a0edbc5 and 47654f3.

📒 Files selected for processing (1)

app/src/org/commcare/fragments/personalId/PersonalIdBackupCodeFragment.java (1 hunks)

🔇 Additional comments (1)

app/src/org/commcare/fragments/personalId/PersonalIdBackupCodeFragment.java (1)

146-146: LGTM! Excellent UX improvement for error message visibility.

This change correctly implements conditional visibility for the error message, ensuring it only appears when there's actual input that's invalid. This prevents confusing users with error messages when the field is empty, which aligns perfectly with the PR objective of fixing backup code error display issues.

The logic is sound: !backupCode1.isEmpty() && !isValid ensures the error message is shown only when there's input AND it's invalid, providing a much cleaner user experience.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

shubham1g5 · 2025-06-06T11:40:07Z

app/src/org/commcare/fragments/personalId/PersonalIdBackupCodeFragment.java

            }
        }

+        binding.connectBackupCodeErrorMessage.setVisibility(!backupCode1.isEmpty() && !isValid ? View.VISIBLE : View.GONE);


we can just do errorText not empty check here ?

even better to have a method like this - https://github.com/dimagi/commcare-android/blob/master/app/src/org/commcare/fragments/personalId/PersonalIdPhotoCaptureFragment.java#L152

We don't want to show any error message before user starts typing, so check for empty.

Also, you are correct to have separate method when its confirmed that there is error/no-error from multiple places. In this case, unnecessarily checks have to be made, with method overhead.

We don't want to show any error message before user starts typing, so check for empty.

why would errorText be non empty in that case ? What I am suggesting here is to tie the visibility to errorText itself and then set or clear errorText if we need to clear the error.

validateBackupCodeInputs() can also do the same thing i guess

Agree, my bad, corrected

Backup code error when not matching criteria

47654f3

Jignesh-dimagi requested review from OrangeAndGreen, pm-dimagi and shubham1g5 June 6, 2025 11:24

Jignesh-dimagi added the skip-integration-tests Skip android tests. label Jun 6, 2025

shubham1g5 reviewed Jun 6, 2025

View reviewed changes

Comment -1

087f92c

shubham1g5 approved these changes Jun 6, 2025

View reviewed changes

shubham1g5 merged commit 4502bb5 into commcare_2.57 Jun 6, 2025
1 of 2 checks passed

shubham1g5 deleted the jignesh/fix/qa_7824 branch June 6, 2025 12:02

This was referenced Jun 11, 2025

Handling Next and Done keys in Backup Code Fragment #3192

Merged

Correct error handling for network requests #3195

Merged

Uh oh!

Backup code error when not matching criteria #3164

Backup code error when not matching criteria #3164

Uh oh!

Conversation

Jignesh-dimagi commented Jun 6, 2025

Technical Summary

Labels and Review

Uh oh!

coderabbitai bot commented Jun 6, 2025

Walkthrough

Possibly related PRs

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

shubham1g5 Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

shubham1g5 Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

Jignesh-dimagi Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

shubham1g5 Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

pm-dimagi Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

Jignesh-dimagi Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)