Skip to content

Timer stopping after activity is paused issue solved #3161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shubham1g5 merged 1 commit into from
Jun 6, 2025
Merged

Timer stopping after activity is paused issue solved #3161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/src/org/commcare/fragments/personalId/PersonalIdPhoneVerificationFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container,
setupInitialState();
setupSmsRetriever();
setupListeners();
startResendTimer();

activity.setTitle(R.string.connect_verify_phone_title);
return binding.getRoot();
Expand Down Expand Up @@ -176,29 +175,30 @@ private void displayOtpError(String message) {
@Override
public void onStart() {
super.onStart();
registerSmsBroadcastReceiver();
}

@Override
public void onResume() {
super.onResume();
startResendTimer();
registerSmsBroadcastReceiver();
KeyboardHelper.showKeyboardOnInput(activity, binding.customOtpView);
}

@Override
public void onPause() {
super.onPause();
stopResendTimer();
try {
activity.unregisterReceiver(smsBroadcastReceiver);
} catch (IllegalArgumentException e) {
e.printStackTrace();

}
}

@Override
public void onStop() {
super.onStop();
stopResendTimer();
}

@Override
Expand Down Expand Up @@ -249,9 +249,9 @@ private void updateVerificationMessage() {
}

private void requestOtp() {
otpRequestTime = new DateTime();
clearOtpError();
if (primaryPhone != null && !primaryPhone.isEmpty()){
otpRequestTime = new DateTime();
otpManager.requestOtp(primaryPhone);
}
}
Expand Down