Cleaned up obsolete PersonalID API calls.

[OrangeAndGreen]

Deleted the old endpoints that will no longer be used from ApiPersonalID, and their corresponding parts in ApiService and ApiEndpoints. All deleted code is unused.

[coderabbitai]

📝 Walkthrough

Walkthrough

This change removes several user account management and authentication-related API methods and endpoint constants from the codebase. Specifically, it deletes public static methods from the ApiPersonalId class that handled password reset, backup code setting, OTP requests and confirmations, and account deactivation. Corresponding string constants for these endpoints are also removed from ApiEndPoints, and related method declarations are deleted from the ApiService interface. No new functionality is introduced, and other unrelated methods remain unchanged.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant ApiPersonalId
    participant ApiService
    participant Server

    Note over Client,Server: Previous flow (now removed)

    Client->>ApiPersonalId: resetPassword / setBackupCode / requestRegistrationOtpPrimary / etc.
    ApiPersonalId->>ApiService: Corresponding API method call
    ApiService->>Server: HTTP request to endpoint
    Server-->>ApiService: Response
    ApiService-->>ApiPersonalId: Callback
    ApiPersonalId-->>Client: Callback result

Loading

Possibly related PRs

• Pm retrofit #2890: Introduces a new Retrofit-based API client, service interface, and endpoints that reorganize and replace the removed user account management and authentication API methods, indicating a direct refactor and replacement of the same functionalities.

Suggested reviewers

• pm-dimagi

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f1931f and ba98a21.

📒 Files selected for processing (3)

• app/src/org/commcare/connect/network/ApiPersonalId.java (0 hunks)
• app/src/org/commcare/connect/network/connectId/ApiEndPoints.java (0 hunks)
• app/src/org/commcare/connect/network/connectId/ApiService.java (0 hunks)

💤 Files with no reviewable changes (3)

• app/src/org/commcare/connect/network/ApiPersonalId.java
• app/src/org/commcare/connect/network/connectId/ApiService.java
• app/src/org/commcare/connect/network/connectId/ApiEndPoints.java

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Lint Code Base

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.