User photo and name #3134
Merged
User photo and name #3134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham1g5
requested changes
May 28, 2025
| String username = personalIdSessionDataViewModel.getPersonalIdSessionData().getUsername(); | ||
| String photoBase64 = personalIdSessionDataViewModel.getPersonalIdSessionData().getPhotoBase64(); | ||
|
|
||
| if (!TextUtils.isEmpty(username)) { |
Contributor
There was a problem hiding this comment.
remove this as username can't be empty at this point.
Comment on lines
127
to
134
| if (!TextUtils.isEmpty(photoBase64)) { | ||
| try { | ||
| byte[] decodedBytes = Base64.decode(photoBase64, Base64.DEFAULT); | ||
| Bitmap bitmap = BitmapFactory.decodeByteArray(decodedBytes, 0, decodedBytes.length); | ||
| binding.userPhoto.setImageBitmap(bitmap); | ||
| } catch (IllegalArgumentException e) { | ||
| Logger.log("photo-decode-error", "Invalid Base64 image: " + e.getMessage()); | ||
| } |
Contributor
There was a problem hiding this comment.
we can reuse displayImage by moving it to MediaUtil.
shubham1g5
reviewed
May 28, 2025
| } | ||
|
|
||
| private void displayImage(String photoAsBase64) { | ||
| String imageData = photoAsBase64.replace(MicroImageActivity.BASE_64_IMAGE_PREFIX, ""); |
Contributor
There was a problem hiding this comment.
where is this code now ?
shubham1g5
requested changes
May 28, 2025
| // Remove the metadata prefix if it exists | ||
| if (base64Image.startsWith("data:image")) { | ||
| int commaIndex = base64Image.indexOf(','); | ||
| if (commaIndex != -1) { |
Contributor
There was a problem hiding this comment.
throw an IllegalStateException if commaIndex == -1 instead.
| byte[] decodedString = Base64.decode(base64Image, Base64.DEFAULT); | ||
| return BitmapFactory.decodeByteArray(decodedString, 0, decodedString.length); | ||
| } catch(Exception e){ | ||
| } catch (Exception e) { |
Contributor
There was a problem hiding this comment.
lets remove the generic catch from here.
shubham1g5
approved these changes
May 28, 2025
app/src/org/commcare/fragments/personalId/PersonalIdBackupCodeFragment.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Added user name and photo at the time of recovery of pin at the backup code page
Technical Summary
Feature Flag
Safety Assurance
Safety story
Automated test coverage
QA Plan
Labels and Review