Name changes as per the new name personalid

[pm-dimagi]

Product Description

Changed the name from the connectId to PersonalId

Technical Summary

Feature Flag

Safety Assurance

Nothing is changed in safety only the name changes

Safety story

Automated test coverage

QA Plan

Labels and Review

• Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
• Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes involve a comprehensive renaming and refactoring of a feature module from "ConnectId" to "PersonalId" across various XML layout, navigation, activity, and fragment files. All fragment class names, navigation directions, argument classes, and associated resource references have been updated to use the "PersonalId" prefix instead of "ConnectId." The navigation graph and start destinations have been similarly renamed, and the relevant XML attributes have been updated. No changes were made to the underlying business logic, control flow, or argument structures—only the naming and references were altered for consistency with the new module identity.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PersonalIdPhoneFragment
    participant PersonalIdPhoneVerificationFragment
    participant PersonalIdBiometricConfigFragment
    participant PersonalIdBackupCodeFragment
    participant PersonalIdPasswordVerificationFragment
    participant PersonalIdMessageFragment

    User->>PersonalIdPhoneFragment: Enter phone number
    PersonalIdPhoneFragment->>PersonalIdPhoneVerificationFragment: Navigate for phone verification
    PersonalIdPhoneVerificationFragment->>PersonalIdBiometricConfigFragment: On verification success, configure biometrics
    PersonalIdBiometricConfigFragment->>PersonalIdBackupCodeFragment: Set up backup code (PIN)
    PersonalIdBackupCodeFragment->>PersonalIdPasswordVerificationFragment: Password verification (if needed)
    PersonalIdPasswordVerificationFragment->>PersonalIdMessageFragment: Show confirmation/message

Loading

Suggested labels

skip-integration-tests

Suggested reviewers

• shubham1g5

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b939e61 and 8f0785a.

📒 Files selected for processing (11)

• app/res/layout/screen_personalid_phoneno.xml (1 hunks)
• app/res/navigation/nav_graph_connectid.xml (10 hunks)
• app/src/org/commcare/activities/connect/ConnectIdActivity.java (5 hunks)
• app/src/org/commcare/fragments/connectId/ConnectIDSecondaryPhoneNumber.java (1 hunks)
• app/src/org/commcare/fragments/connectId/ConnectIdPhoneFragment.java (1 hunks)
• app/src/org/commcare/fragments/connectId/PersonalIdBackupCodeFragment.java (5 hunks)
• app/src/org/commcare/fragments/connectId/PersonalIdBiometricConfigFragment.java (5 hunks)
• app/src/org/commcare/fragments/connectId/PersonalIdMessageFragment.java (8 hunks)
• app/src/org/commcare/fragments/connectId/PersonalIdPasswordVerificationFragment.java (3 hunks)
• app/src/org/commcare/fragments/connectId/PersonalIdPhoneFragment.java (5 hunks)
• app/src/org/commcare/fragments/connectId/PersonalIdPhoneVerificationFragment.java (7 hunks)

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: Jignesh-dimagi
PR: dimagi/commcare-android#3093
File: app/res/navigation/nav_graph_connect_messaging.xml:41-45
Timestamp: 2025-05-09T10:57:41.073Z
Learning: In the CommCare Android codebase, the navigation graph for Connect messaging (`nav_graph_connect_messaging.xml`) intentionally uses `channel_id` as the argument name in the connectMessageFragment, despite using `channelId` in other parts of the same navigation graph. This naming difference is by design in the refactored code.

app/src/org/commcare/fragments/connectId/PersonalIdBiometricConfigFragment.java (1)

Learnt from: pm-dimagi
PR: dimagi/commcare-android#2949
File: app/src/org/commcare/fragments/connectId/ConnectIdBiometricConfigFragment.java:235-236
Timestamp: 2025-02-04T21:29:29.594Z
Learning: The empty performPasswordUnlock method in ConnectIdBiometricConfigFragment is intentionally left empty and should not be flagged in reviews.

app/res/navigation/nav_graph_connectid.xml (1)

Learnt from: Jignesh-dimagi
PR: dimagi/commcare-android#3093
File: app/res/navigation/nav_graph_connect_messaging.xml:41-45
Timestamp: 2025-05-09T10:57:41.073Z
Learning: In the CommCare Android codebase, the navigation graph for Connect messaging (`nav_graph_connect_messaging.xml`) intentionally uses `channel_id` as the argument name in the connectMessageFragment, despite using `channelId` in other parts of the same navigation graph. This naming difference is by design in the refactored code.

🧬 Code Graph Analysis (3)

app/src/org/commcare/fragments/connectId/PersonalIdBackupCodeFragment.java (1)

app/src/org/commcare/fragments/connectId/PersonalIdPhoneVerificationFragment.java (1)

• PersonalIdPhoneVerificationFragment (63-681)

app/src/org/commcare/fragments/connectId/ConnectIDSecondaryPhoneNumber.java (2)

app/src/org/commcare/connect/ConnectConstants.java (1)

• ConnectConstants (8-84)

app/src/org/commcare/fragments/connectId/PersonalIdPhoneVerificationFragment.java (1)

• PersonalIdPhoneVerificationFragment (63-681)

app/src/org/commcare/fragments/connectId/PersonalIdPhoneFragment.java (1)

app/src/org/commcare/connect/ConnectConstants.java (1)

• ConnectConstants (8-84)

🔇 Additional comments (36)

app/res/layout/screen_personalid_phoneno.xml (1)

9-9: Rename successfully completed in fragment reference

The tools:context attribute has been correctly updated to reference the renamed fragment PersonalIdPhoneFragment. This update supports the consistent renaming from "ConnectId" to "PersonalId" across the codebase.

app/src/org/commcare/fragments/connectId/ConnectIdPhoneFragment.java (1)

105-105: Successful constant reference update

The class reference has been properly updated from ConnectIdPhoneVerificationFragment to PersonalIdPhoneVerificationFragment for the method constant. This maintains consistency with the renaming effort across the codebase.

app/src/org/commcare/fragments/connectId/ConnectIDSecondaryPhoneNumber.java (2)

182-182: Correctly updated verification method reference

The reference to ConnectIdPhoneVerificationFragment.MethodVerifyAlternate has been appropriately replaced with PersonalIdPhoneVerificationFragment.MethodVerifyAlternate, maintaining the navigation flow for the alternate phone verification.

---

187-187: Correctly updated verification method reference

The reference to ConnectIdPhoneVerificationFragment.MethodVerifyAlternate has been appropriately replaced with PersonalIdPhoneVerificationFragment.MethodVerifyAlternate, maintaining consistency with the renaming pattern throughout the codebase.

app/src/org/commcare/fragments/connectId/PersonalIdBackupCodeFragment.java (5)

47-50: Class name properly updated in documentation

The fragment class name has been correctly updated in the JavaDoc comment to reflect the rename from ConnectIdPinFragment to PersonalIdBackupCodeFragment.

---

192-196: Updated argument bundle class references

All references to the generated arguments class have been updated from ConnectIdPinFragmentArgs to PersonalIdBackupCodeFragmentArgs, ensuring proper compilation and navigation flow.

---

423-423: Verification method constant reference updated

The constant reference has been updated from the old class to the new PersonalIdPhoneVerificationFragment.MethodRecoveryPrimary, maintaining functionality in the recovery flow.

---

490-490: Verification method constant reference updated

The reference to PersonalIdPhoneVerificationFragment.MethodRecoveryAlternate is correctly updated, ensuring proper alternate phone verification during recovery.

---

508-529: Navigation direction references updated

All navigation helper methods have been updated to use PersonalIdBackupCodeFragmentDirections instead of the previous ConnectIdPinFragmentDirections. This ensures navigation continues to work properly throughout the fragment flow.

app/src/org/commcare/fragments/connectId/PersonalIdPhoneFragment.java (1)

28-28: Class renaming from ConnectIDSignupFragment to PersonalIdPhoneFragment looks consistent.

The class has been renamed while maintaining the same functionality. All related references to binding, arguments, and navigation directions have been properly updated to match the new naming convention.

Also applies to: 48-48, 52-52, 61-61, 82-84, 434-444

app/src/org/commcare/fragments/connectId/PersonalIdBiometricConfigFragment.java (1)

18-18: Class renaming from ConnectIdBiometricConfigFragment to PersonalIdBiometricConfigFragment is consistent.

All references have been properly updated including view bindings, static imports, constructor, arguments, and navigation directions while maintaining the original functionality.

Also applies to: 34-34, 39-39, 48-48, 51-51, 80-80, 85-85, 307-312

app/src/org/commcare/fragments/connectId/PersonalIdPasswordVerificationFragment.java (1)

43-43: Class renaming from ConnectIdPasswordVerificationFragment to PersonalIdPasswordVerificationFragment is consistent.

All argument extraction and navigation direction methods have been properly updated while preserving the original functionality.

Also applies to: 108-110, 260-273

app/src/org/commcare/activities/connect/ConnectIdActivity.java (1)

7-7: References to renamed fragments have been properly updated.

All imports, method return types, instance checks, and navigation directions now correctly reference the renamed PersonalId classes rather than the previous ConnectId versions, maintaining the same functionality.

Also applies to: 14-14, 71-78, 95-145, 166-172

app/src/org/commcare/fragments/connectId/PersonalIdPhoneVerificationFragment.java (7)

31-31: Import statement updated correctly.

The import statement has been properly updated to reference the new ScreenPersonalidPhoneVerifyBinding class, maintaining consistency with the renaming from ConnectId to PersonalId.

---

60-63: Class name and JavaDoc updated consistently.

The class declaration and JavaDoc reference have been properly renamed from ConnectIdPhoneVerificationFragment to PersonalIdPhoneVerificationFragment, aligning with the PR objectives.

---

79-79: Binding type updated properly.

The binding variable type has been correctly updated to ScreenPersonalidPhoneVerifyBinding to match the renamed layout resource.

---

129-129: Binding inflation call updated accordingly.

The binding inflation call has been updated to use the new ScreenPersonalidPhoneVerifyBinding class, consistent with the renamed resources.

---

159-165: Argument retrieval updated consistently.

All references to ConnectIdPhoneVerificationFragmentArgs have been properly updated to PersonalIdPhoneVerificationFragmentArgs, maintaining the functionality while updating the naming.

---

604-604: Reference to method constant updated.

The reference to ConnectIdPhoneVerificationFragment.MethodRecoveryPrimary has been correctly updated to use the renamed class PersonalIdPhoneVerificationFragment.

---

638-666: Navigation direction methods updated properly.

All navigation method return statements have been updated to use PersonalIdPhoneVerificationFragmentDirections instead of ConnectIdPhoneVerificationFragmentDirections, ensuring consistent navigation within the renamed structure.

app/src/org/commcare/fragments/connectId/PersonalIdMessageFragment.java (7)

19-19: Import statement updated correctly.

The import statement has been properly updated to reference the new ScreenPersonalidMessageBinding class, maintaining consistency with the renaming scheme.

---

30-30: Class name updated consistently.

The class declaration has been properly renamed from ConnectIdMessageFragment to PersonalIdMessageFragment, aligning with the PR objectives.

---

45-45: Binding variable type updated appropriately.

The binding variable type has been correctly updated to ScreenPersonalidMessageBinding to match the renamed layout resource.

---

50-51: Binding inflation call updated accordingly.

The binding inflation call has been updated to use the new ScreenPersonalidMessageBinding class, consistent with the renamed resources.

---

93-100: Argument retrieval updated consistently.

All references to ConnectIdMessageFragmentArgs have been properly updated to PersonalIdMessageFragmentArgs, maintaining the argument retrieval functionality while updating the naming.

---

136-137: References to method constants updated properly.

All references to method constants from the previous ConnectIdPhoneVerificationFragment class have been correctly updated to use PersonalIdPhoneVerificationFragment, ensuring consistent use of the renamed classes across the codebase.

Also applies to: 156-157, 162-164, 182-183

---

209-234: Navigation direction methods updated properly.

All navigation method return statements have been updated to use PersonalIdMessageFragmentDirections instead of ConnectIdMessageFragmentDirections, ensuring consistent navigation within the renamed structure.

app/res/navigation/nav_graph_connectid.xml (9)

5-6: Navigation graph ID and start destination updated correctly.

The navigation graph ID has been properly changed from nav_graph_connectid to nav_graph_personalid, and the start destination has been updated from connectid_signup_fragment to personalid_phone_fragment, aligning with the renaming scheme.

---

25-37: Biometric config fragment updated consistently.

The biometric config fragment's ID, class name, label, and layout references have been properly updated to use the "personalid" prefix. All associated action destinations and popUpTo references have been updated accordingly.

---

44-107: Phone verification fragment and its actions updated correctly.

The phone verification fragment's ID, class name, label, and layout references have been properly updated to use the "personalid" prefix. All associated action destinations and popUpTo references have been updated accordingly to maintain the navigation flow.

---

110-169: Message fragment updated consistently.

The message fragment's ID, class name, label, and layout references have been properly updated to use the "personalid" prefix. All associated action destinations and popUpTo references have been updated accordingly to maintain the navigation flow.

---

172-218: Backup code fragment updated consistently.

The backup code fragment's ID, class name, and label have been properly updated from "connectid_pin" to "personalid_backup_code". All associated action destinations and popUpTo references have been updated accordingly to maintain the navigation flow.

---

220-252: Password verification fragment partially updated.

While the class name has been updated to PersonalIdPasswordVerificationFragment, the fragment ID is still connectid_password. This is acceptable as long as all references to this ID are consistent throughout the navigation graph.

---

255-286: Phone fragment updated consistently.

The phone fragment's ID, class name, and layout references have been properly updated to use the "personalid" prefix. All associated action destinations have been updated accordingly to maintain the navigation flow.

---

291-309: Secondary phone fragment actions updated correctly.

While the secondary phone fragment itself retains its original ID and class name, all of its action destinations have been properly updated to reference the renamed fragments, ensuring consistent navigation.

---

311-346: Remaining fragments' actions updated correctly.

The user deactivate OTP verification fragment and phone number fragment have maintained their original IDs and class names, but their action destinations have been properly updated to reference the renamed fragments, ensuring consistent navigation throughout the application.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.