Pm-fix direction issue with password , "null" issue, #3091
Conversation
| delivery.entityName = json.getString(META_ENTITY_NAME); | ||
| delivery.reason = json.getString(META_REASON); | ||
|
|
||
| delivery.reason = JsonExtensions.optStringSafe(json, META_REASON, ""); |
There was a problem hiding this comment.
I think we want this to default to null, not empty string. Later we check for null and show pending flags instead when no reason is provided
| delivery.entityName = json.getString(META_ENTITY_NAME); | ||
| delivery.reason = json.getString(META_REASON); | ||
|
|
||
| delivery.reason = JsonExtensions.optStringSafe(json, META_REASON,null); |
| ((ConnectIdActivity)activity).forgotPassword=false; | ||
| ((ConnectIdActivity)activity).forgotPin=false; | ||
| SmsRetrieverClient client = SmsRetriever.getClient(getActivity());// starting the SmsRetriever API |
There was a problem hiding this comment.
Is this something we missed during merge or an existing regression ?
There was a problem hiding this comment.
no i think this was existing flow this is nothing we have missed
There was a problem hiding this comment.
you mean it's not a regression with current beta ?
There was a problem hiding this comment.
It came up in nitin notice from there, i Have to reconfirm that is case in current beta or not because as per the code i have seen it should be existing bug because it is a special scenario when user is clicking back on secondary phone verification during recovery it happens only then
There was a problem hiding this comment.
if it's not a regression, I am fine with not fixing this.
There was a problem hiding this comment.
need ur final verdict that should remove this or remain as it is
There was a problem hiding this comment.
Just saw Mary's comment on https://dimagi.atlassian.net/browse/QA-7738 and given that we should not resolve it, I am worried this might open another bug here or there.
…llable DB column)
Product Description
Fixed qa bugs
QA-7735
https://dimagi.atlassian.net/browse/CCCT-607
https://dimagi.atlassian.net/browse/QA-7738
Technical Summary
Feature Flag
Safety Assurance
Safety story
Automated test coverage
QA Plan
Labels and Review