Use constructor for delivery details

[shubham1g5]

Product Description

Minor refactor to utilize constructor correctly.
Motivated by https://github.com/dimagi/commcare-android/pull/3084/files#r2079052133

Labels and Review

• Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
• Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes remove the no-argument constructor from the ConnectDeliveryDetails class and update its parameterized constructor by reordering parameters—placing unitId first—and changing the type of approvedPercentage from long to double. Correspondingly, the instantiation of ConnectDeliveryDetails objects in ConnectDeliveryProgressDeliveryFragment is refactored to use the new constructor signature, replacing the previous pattern of using the default constructor and property setters. No other logic or methods are altered.

Sequence Diagram(s)

sequenceDiagram
    participant Fragment as ConnectDeliveryProgressDeliveryFragment
    participant Model as ConnectDeliveryDetails

    Fragment->>Model: new ConnectDeliveryDetails(unitId, deliveryName, approvedCount, pendingCount, totalAmount, remainingDays, approvedPercentage)
    Note right of Model: All properties set via constructor

Loading

Suggested labels

skip-integration-tests

Suggested reviewers

• OrangeAndGreen
• avazirna

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 46cdb07 and 523e7de.

📒 Files selected for processing (2)

• app/src/org/commcare/android/database/connect/models/ConnectDeliveryDetails.java (1 hunks)
• app/src/org/commcare/fragments/connect/ConnectDeliveryProgressDeliveryFragment.java (1 hunks)

🔇 Additional comments (2)

app/src/org/commcare/fragments/connect/ConnectDeliveryProgressDeliveryFragment.java (1)

159-160: Constructor usage improvement looks good!

The refactoring to use the parameterized constructor directly for ConnectDeliveryDetails instead of the previous approach (using no-arg constructor followed by setter calls) is a good improvement. This approach ensures all required properties are set during object creation, making the code more maintainable and less error-prone.

app/src/org/commcare/android/database/connect/models/ConnectDeliveryDetails.java (1)

13-15: Constructor improvements look good!

The changes to the constructor are well-implemented:

1. Reordering parameters to place unitId first creates a more logical parameter order
2. Changing approvedPercentage from long to double is appropriate for percentage values, allowing for decimal precision
3. Removing the no-argument constructor enforces proper initialization of all properties

These changes align with good object-oriented design principles by ensuring proper object initialization through the constructor.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.