Review drawables #3070
Review drawables #3070
Conversation
📝 WalkthroughWalkthroughThis change introduces a large set of new drawable resources, including vector icons and shape drawables, primarily to support new UI elements and visual states for ConnectID and Connect features. The update adds icons for messaging, delivery, payments, job statuses, and various UI controls, as well as several shape drawables for backgrounds and rounded corners. Multiple new color resources are defined for messaging backgrounds and text. The Sequence Diagram(s)Skipped: The changes are resource additions and reorganizations, with no new feature logic or control flow introduced. Possibly related PRs
Suggested labels
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 69
♻️ Duplicate comments (1)
app/res/drawable/shape_connect_delivery_rejected.xml (1)
1-5: Duplicate: consider defining intrinsic size for badge shapes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (116)
app/res/drawable-hdpi/cloud_backup.pngis excluded by!**/*.pngapp/res/drawable-hdpi/ic_connect_delivery.pngis excluded by!**/*.pngapp/res/drawable-hdpi/ic_connect_download_green.pngis excluded by!**/*.pngapp/res/drawable-hdpi/ic_connect_expired.pngis excluded by!**/*.pngapp/res/drawable-hdpi/ic_connect_learning.pngis excluded by!**/*.pngapp/res/drawable-hdpi/ic_connect_new_opportunity.pngis excluded by!**/*.pngapp/res/drawable-hdpi/ic_marker.pngis excluded by!**/*.pngapp/res/drawable-hdpi/mobile_support.pngis excluded by!**/*.pngapp/res/drawable-hdpi/monetary_support.pngis excluded by!**/*.pngapp/res/drawable-ldpi/arrow_right.pngis excluded by!**/*.pngapp/res/drawable-ldpi/book.pngis excluded by!**/*.pngapp/res/drawable-ldpi/calendar_heart.pngis excluded by!**/*.pngapp/res/drawable-ldpi/checklist.pngis excluded by!**/*.pngapp/res/drawable-ldpi/cloud_backup.pngis excluded by!**/*.pngapp/res/drawable-ldpi/ic_connect_delivery.pngis excluded by!**/*.pngapp/res/drawable-ldpi/ic_connect_download_green.pngis excluded by!**/*.pngapp/res/drawable-ldpi/ic_connect_expired.pngis excluded by!**/*.pngapp/res/drawable-ldpi/ic_connect_learning.pngis excluded by!**/*.pngapp/res/drawable-ldpi/ic_connect_new_opportunity.pngis excluded by!**/*.pngapp/res/drawable-ldpi/mobile_support.pngis excluded by!**/*.pngapp/res/drawable-ldpi/monetary_support.pngis excluded by!**/*.pngapp/res/drawable-ldpi/money.pngis excluded by!**/*.pngapp/res/drawable-ldpi/money2.pngis excluded by!**/*.pngapp/res/drawable-ldpi/report_approved.pngis excluded by!**/*.pngapp/res/drawable-ldpi/time.pngis excluded by!**/*.pngapp/res/drawable-ldpi/watch.pngis excluded by!**/*.pngapp/res/drawable-mdpi/arrow_right.pngis excluded by!**/*.pngapp/res/drawable-mdpi/book.pngis excluded by!**/*.pngapp/res/drawable-mdpi/calendar_heart.pngis excluded by!**/*.pngapp/res/drawable-mdpi/checklist.pngis excluded by!**/*.pngapp/res/drawable-mdpi/cloud_backup.pngis excluded by!**/*.pngapp/res/drawable-mdpi/connect_arrow_down.pngis excluded by!**/*.pngapp/res/drawable-mdpi/connect_edittext_cancel.pngis excluded by!**/*.pngapp/res/drawable-mdpi/connect_ic_inventory.pngis excluded by!**/*.pngapp/res/drawable-mdpi/ic_connect_delivery.pngis excluded by!**/*.pngapp/res/drawable-mdpi/ic_connect_download_green.pngis excluded by!**/*.pngapp/res/drawable-mdpi/ic_connect_expired.pngis excluded by!**/*.pngapp/res/drawable-mdpi/ic_connect_learning.pngis excluded by!**/*.pngapp/res/drawable-mdpi/ic_connect_new_opportunity.pngis excluded by!**/*.pngapp/res/drawable-mdpi/ic_marker.pngis excluded by!**/*.pngapp/res/drawable-mdpi/mobile_support.pngis excluded by!**/*.pngapp/res/drawable-mdpi/monetary_support.pngis excluded by!**/*.pngapp/res/drawable-mdpi/money.pngis excluded by!**/*.pngapp/res/drawable-mdpi/money2.pngis excluded by!**/*.pngapp/res/drawable-mdpi/report_approved.pngis excluded by!**/*.pngapp/res/drawable-mdpi/time.pngis excluded by!**/*.pngapp/res/drawable-mdpi/watch.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/arrow_right.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/book.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/calendar_heart.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/checklist.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/cloud_backup.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/connect_arrow_down.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/connect_edittext_cancel.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/connect_ic_inventory.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/ic_connect_delivery.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/ic_connect_download_green.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/ic_connect_expired.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/ic_connect_learning.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/ic_connect_new_opportunity.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/ic_marker.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/mobile_support.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/monetary_support.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/money.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/money2.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/report_approved.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/time.pngis excluded by!**/*.pngapp/res/drawable-xhdpi/watch.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/arrow_right.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/book.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/calendar_heart.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/checklist.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/cloud_backup.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/connect_arrow_down.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/connect_edittext_cancel.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/connect_ic_inventory.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/ic_connect_delivery.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/ic_connect_download_green.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/ic_connect_expired.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/ic_connect_learning.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/ic_connect_new_opportunity.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/ic_marker.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/mobile_support.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/monetary_support.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/money.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/money2.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/report_approved.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/time.pngis excluded by!**/*.pngapp/res/drawable-xxhdpi/watch.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/arrow_right.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/book.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/calendar_heart.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/checklist.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/cloud_backup.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/connect_arrow_down.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/connect_edittext_cancel.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/connect_ic_inventory.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/ic_connect_delivery.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/ic_connect_download_green.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/ic_connect_expired.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/ic_connect_learning.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/ic_connect_new_opportunity.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/mobile_support.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/monetary_support.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/money.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/money2.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/report_approved.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/time.pngis excluded by!**/*.pngapp/res/drawable-xxxhdpi/watch.pngis excluded by!**/*.pngapp/res/drawable/cert_1.pngis excluded by!**/*.pngapp/res/drawable/flower.pngis excluded by!**/*.pngapp/res/drawable/ic_connect_delivery_progress.pngis excluded by!**/*.pngapp/res/drawable/ic_connect_message_send.pngis excluded by!**/*.pngapp/res/drawable/ic_dimagi_logo.pngis excluded by!**/*.pngapp/res/drawable/local_library.pngis excluded by!**/*.pngapp/res/drawable/logo_white.pngis excluded by!**/*.png
📒 Files selected for processing (50)
app/res/drawable/backup.xml(1 hunks)app/res/drawable/connect_rounded_corner_grey.xml(1 hunks)app/res/drawable/connect_rounded_corner_light_green.xml(1 hunks)app/res/drawable/connect_rounded_corner_orange_yellow.xml(1 hunks)app/res/drawable/connect_rounded_corner_teslish_blue.xml(1 hunks)app/res/drawable/home_saved.xml(1 hunks)app/res/drawable/ic_connect_arrow_forward.xml(1 hunks)app/res/drawable/ic_connect_arrow_forward_24px.xml(1 hunks)app/res/drawable/ic_connect_check_circle.xml(1 hunks)app/res/drawable/ic_connect_close.xml(1 hunks)app/res/drawable/ic_connect_delivery_approved.xml(1 hunks)app/res/drawable/ic_connect_delivery_check_circle.xml(1 hunks)app/res/drawable/ic_connect_delivery_pending.xml(1 hunks)app/res/drawable/ic_connect_delivery_rejected.xml(1 hunks)app/res/drawable/ic_connect_directory_sync.xml(1 hunks)app/res/drawable/ic_connect_message_editext_bg_24_border.xml(1 hunks)app/res/drawable/ic_connect_message_large.xml(1 hunks)app/res/drawable/ic_connect_message_read.xml(1 hunks)app/res/drawable/ic_connect_message_receiver_bg.xml(1 hunks)app/res/drawable/ic_connect_message_receiver_edge.xml(1 hunks)app/res/drawable/ic_connect_message_sender_bg.xml(1 hunks)app/res/drawable/ic_connect_message_sender_edge.xml(1 hunks)app/res/drawable/ic_connect_message_unread.xml(1 hunks)app/res/drawable/ic_connect_messaging_base.xml(1 hunks)app/res/drawable/ic_connect_messaging_unread.xml(1 hunks)app/res/drawable/ic_connect_pager_indicator.xml(1 hunks)app/res/drawable/ic_connect_payment_earned.xml(1 hunks)app/res/drawable/ic_connect_payment_recevied_check.xml(1 hunks)app/res/drawable/ic_connect_payment_revert.xml(1 hunks)app/res/drawable/ic_connect_payment_status_not_transferred.xml(1 hunks)app/res/drawable/ic_connect_payment_status_transferred.xml(1 hunks)app/res/drawable/ic_connect_payment_transferred.xml(1 hunks)app/res/drawable/ic_connect_thumb_up.xml(1 hunks)app/res/drawable/ic_connect_yellow_dot.xml(1 hunks)app/res/drawable/ic_contact_support_30.xml(1 hunks)app/res/drawable/install_start.xml(1 hunks)app/res/drawable/login_edit_text.xml(1 hunks)app/res/drawable/progress_ring.xml(1 hunks)app/res/drawable/rounded_top_corners.xml(1 hunks)app/res/drawable/shape_border_10px_blue.xml(1 hunks)app/res/drawable/shape_connect_delivery_approved.xml(1 hunks)app/res/drawable/shape_connect_delivery_pending.xml(1 hunks)app/res/drawable/shape_connect_delivery_rejected.xml(1 hunks)app/res/values/attrs.xml(2 hunks)app/res/values/colors.xml(2 hunks)app/res/values/dimens.xml(1 hunks)app/res/values/mydialog.xml(0 hunks)app/res/values/strings.xml(18 hunks)app/res/values/styles.xml(1 hunks)app/res/values/themes.xml(1 hunks)
💤 Files with no reviewable changes (1)
- app/res/values/mydialog.xml
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Lint Code Base
🔇 Additional comments (42)
app/res/drawable/install_start.xml (1)
1-1: Add XML declaration for consistency
Including<?xml version="1.0" encoding="utf-8"?>ensures that this drawable matches the formatting and encoding declarations of other vector XML resources, reducing the risk of parser inconsistencies.app/res/drawable/home_saved.xml (1)
9-9: No review needed for formatting-only change. The removal of a trailing newline has no functional impact.app/res/drawable/shape_connect_delivery_approved.xml (1)
1-5: Drawable implementation looks correct
The oval shape with@color/connect_light_greencorrectly represents the “approved” delivery status, and the naming/structure align with related status drawables. No issues found.app/res/drawable/connect_rounded_corner_orange_yellow.xml (1)
3-3: Ensure the color resource exists.
Verify that@color/connect_orange_yellowis defined incolors.xmland matches the intended design palette.app/res/drawable/ic_connect_pager_indicator.xml (1)
10-12: Confirm bottom-corner rounding intent.
This drawable only rounds the top-left and top-right corners. Please verify whether the bottom corners should remain square or if they also require a radius to match the design specification.app/res/drawable/ic_connect_delivery_pending.xml (1)
1-10: Approve addition of delivery-pending icon.The vector drawable is well-formed: width/height/viewport align with Android guidelines, and the pathData correctly draws the circular clock shape.
app/res/drawable/ic_connect_thumb_up.xml (1)
1-5: Approve thumb-up icon implementation.The vector’s dimensions and pathData correctly represent the thumb-up graphic, and it integrates seamlessly with the Connect feature set.
app/res/drawable/ic_connect_message_receiver_bg.xml (1)
1-9: Approve message-receiver background shape.The shape’s solid fill and corner radii correctly produce the intended bubble appearance, matching sender/receiver design patterns.
app/res/drawable/ic_connect_delivery_rejected.xml (1)
1-9: Approve delivery-rejected icon.The vector attributes and pathData correctly implement the “X” shape, and the 24dp sizing aligns with other delivery status icons.
app/res/drawable/ic_connect_check_circle.xml (1)
1-5: Approve check-circle icon.The grouping and clipping path ensure the check mark sits cleanly within the circle. Viewport, dimensions, and pathData are correct.
app/res/drawable/ic_contact_support_30.xml (1)
4-4: Approve white fill usage
Using@android:color/whitehere is consistent with platform resources and avoids hard-coding the hex value.app/res/drawable/ic_connect_message_sender_edge.xml (1)
7-8: Verify pathData coordinate extents
The control point13.2245,0lies outside the 8×8 viewport. Please render this on different densities to confirm it behaves as intended, or normalize the coordinates within the viewport.app/res/drawable/ic_connect_payment_transferred.xml (1)
6-9: Confirm clip-path support on all target APIs
The<clip-path>element requires API 21+ or the AndroidX VectorDrawable backport. Double-check yourminSdkVersionand Gradle config to ensure this resource will render correctly on older devices.app/res/drawable/ic_connect_message_receiver_edge.xml (1)
7-8: Verify negative pathData values
The curve uses a negative control point (-5.2245,0) which may clip part of the shape. Please test rendering across screen densities and consider adjusting the path to fit entirely within the viewport.app/res/drawable/ic_connect_payment_revert.xml (1)
2-5: Verify icon dimensions against design spec
This drawable is sized at 20dp × 20dp, whereas other payment icons (e.g., the checkmark) use 16dp. Confirm that the larger size is intentional for UI consistency or adjust to match the standard icon dimensions.app/res/drawable/ic_connect_payment_earned.xml (1)
2-4: Verify icon size consistency
This drawable is defined at42dp×42dp, whereas other Connect/payment icons (e.g.,ic_connect_payment_status_not_transferred.xml) use24dp×24dp. Please confirm the intended size and align with the rest of the icon set.app/res/values/themes.xml (2)
80-80: Overflow icon resource updated correctly
Using the new@drawable/ic_connect_action_overflowaligns with the updated Connect iconography.
80-80: Verify overflow icon resource exists
Ensure that theic_connect_action_overflowdrawable file is included in this PR and that the path/name matches exactly.app/res/values/attrs.xml (9)
3-4: New AspectRatioLayout attributes look good.
Theratio_widthandratio_heightattributes are clearly defined with thefloatformat and will enable proper aspect-ratio handling.
6-15: New global UI color attributes added.
The added attributesdetail_even_row_colorthroughentity_select_title_text_colorprovide flexible theming hooks for lists and headers. Consider documenting their intended use in the style guide.
23-23: Addedshrinkable_viewfor ShrinkingLinearLayout.
This newreference-only attribute aligns with the existing pattern for view IDs.
34-34: ResizingTextViewtext_size_smalladded appropriately.
The dimension/ reference format is correct for adaptive text sizes.
37-38: Filter select color attributes extended.
Addingfilter_select_background_colorandfilter_select_text_colorprovides better control over filter UI.
41-42: TabbedDetailView row color customization.
The neweven_row_colorandodd_row_colorattributes will enhance list styling.
46-49: ClippingView dimension attributes added correctly.
These floating-point attributes (clip_start_x,clip_start_y,clip_width,clip_height) will allow precise clipping, andclip_corner_radiusis already defined.
53-53: FilePreferencefile_typeattribute added.
Thisstringattribute is straightforward for specifying file‐type hints in preferences.
119-136: RoundedButton styleable attributes.
The comprehensive set of attributes (roundButtonHeight,roundButtonRadius, icon tinting, padding, borders, etc.) is well defined and follows Android best practices.app/res/values/strings.xml (15)
21-23: Configuration endpoints and defaults.
The new keyskey_server,your_comment, andsupport_email_address_defaultprovide sensible defaults for server access and UI text.
62-62: Region marker closure.
The<!-- endregion -->comment properly closes the preceding region.
80-80: Notification default title added.
Introducingnotification_message_titlestandardizes the notification header.
97-97: Single‐valuepanesstring.
The keypaneswith the sole value "one" may be too generic. Confirm its usage or rename for clarity.Please verify where
@string/panesis referenced and ensure the value is correct.
103-103: Managed configuration profile URL.
managed_configuration_profile_urlnow holds the placeholder for the CommCare App link.
109-109:accept_locationstring remains correct.
No changes needed; it stays translatable for location prompts.
121-121:proceedlabel standardized.
Uppercase "PROCEED" aligns with other action labels like "CANCEL."
124-124: Collect Strings region marker.
The<!-- Start Collect Strings -->marker is useful for grouping. Maintain consistency with other region markers.
219-219: Overlappingreviewkey.
Thereviewkey (value "Continue") could collide withreview_dataor other review-prefixed keys. Consider renaming toreview_actionfor disambiguation.Please confirm there are no collisions in code references.
344-345: Messaging notification channel strings added.
The newnotification_channel_messaging_titleandnotification_channel_messaging_descriptionkeys complete the channel setup.
406-413: ConnectID post-login UI strings.
New keys (connect_id_enabled,login_password_by_connect,login_welcome_connect_signed_in, etc.) support the ConnectID-enabled flows. Ensure UI logic hooks them correctly.
536-545: Connect messaging channel UI labels.
Consent prompts and preview labels cover the full messaging consent flow.
620-623: Additional visit summary variants.
Addingremaining_tomorrowandremaining_todayenhances clarity for time-sensitive progress.
648-649: App ID not found & audio notification added.
The newapp_with_id_not_foundandaudio_recording_notificationresources cover missing-app and recording states.
385-385: Location wait prompt extended.
wait_for_location_fiximproves user feedback when awaiting GPS fixes.
|
|
||
| <item name="login_screen_hide_all_cuttoff" type="integer">200</item> | ||
| <item name="login_screen_hide_banner_cuttoff" type="integer">250</item> | ||
| <string name="remote_form_payload_url" /> |
There was a problem hiding this comment.
Empty remote_form_payload_url.
This string is self-closing with no content. Either supply a default endpoint or remove it if unused to prevent null or empty-string issues.
🤖 Prompt for AI Agents (early access)
In app/res/values/strings.xml at line 73, the string resource "remote_form_payload_url" is empty and self-closing, which can cause null or empty string issues. Fix this by either providing a valid default URL value inside the string tag or remove the entire string resource if it is not used anywhere in the app.
There was a problem hiding this comment.
Ignore for now as its legacy code and doesn't require any changes here
There was a problem hiding this comment.
@Jignesh-dimagi Understood. I'll ignore this issue since it's legacy code that doesn't require changes. Moving forward with the rest of the review.
✏️ Learnings added
Learnt from: Jignesh-dimagi
PR: dimagi/commcare-android#3070
File: app/res/values/strings.xml:73-73
Timestamp: 2025-05-07T06:50:52.505Z
Learning: The empty `remote_form_payload_url` string resource in strings.xml is intentional legacy code and should be preserved as-is.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
| <string name="connect_messaging_message_notification_title">🔔 New Message 🔔</string> | ||
| <string name="connect_messaging_message_notification_message">You received a new message from %s, press here to view.</string> | ||
| <string name="connect_messaging_channel_notification_title">🔔 New Channel 🔔</string> | ||
| <string name="connect_messaging_channel_notification_message">A new messaging channel is available from %s, press here to view</string> |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Notification messages use emojis.
Emojis in connect_messaging_message_notification_title and channel notification keys may not render on all devices/locales. Consider a text-only fallback or removing them.
🤖 Prompt for AI Agents (early access)
In app/res/values/strings.xml around lines 547 to 550, the notification title strings include emojis which may not render correctly on all devices or locales. To fix this, remove the emojis from the string values or provide alternative text-only versions of these notification titles to ensure consistent display across all platforms.
There was a problem hiding this comment.
Its safe to display emojis
There was a problem hiding this comment.
@Jignesh-dimagi I understand that emojis are safe to display in your application. Thank you for confirming this.
✏️ Learnings added
Learnt from: Jignesh-dimagi
PR: dimagi/commcare-android#3070
File: app/res/values/strings.xml:547-550
Timestamp: 2025-05-07T06:53:45.889Z
Learning: Emojis in notification strings (like the bell emoji 🔔) are acceptable in this application as confirmed by the developer.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!
Product Description
This has all drawables from dv/connect_initial to master
Technical Summary
https://dimagi.atlassian.net/browse/CCCT-1086
Feature Flag
This is review
Safety Assurance
Labels and Review