-
-
Notifications
You must be signed in to change notification settings - Fork 45
Pm qa regression #3061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Pm qa regression #3061
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
907eb16
fixed signup design, refactored the code for connect and connect id
pm-dimagi 96fed5f
-fixed user redicrection for wrong pin, and user deactivation flow
pm-dimagi 1c46eda
-fixed startTimer on resume instead of oncreate
pm-dimagi bafef8c
fixed startTimer on resume instead of oncreate, fixed missed code on …
pm-dimagi 511407b
-removed connect code
pm-dimagi db293c8
-fixed scroll issue, configure biometric issue, change phone number i…
pm-dimagi fc7e407
-name covention change
pm-dimagi a77fc97
-removed skip phone number check , introduced phone is valid or not ,…
pm-dimagi 2010680
lint
shubham1g5 85216e6
more cleanup
shubham1g5 e82def0
-removed on create
pm-dimagi 62de9b8
-removed connectManager calls
pm-dimagi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,158 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <layout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:app="http://schemas.android.com/apk/res-auto"> | ||
|
|
||
| <LinearLayout | ||
| android:layout_width="match_parent" | ||
| android:layout_height="fill_parent" | ||
| android:background="@color/white" | ||
| android:orientation="vertical"> | ||
|
|
||
| <ImageView | ||
| android:id="@+id/company_logo" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="40dp" | ||
| android:layout_gravity="center" | ||
| android:layout_marginTop="40dp" | ||
| android:contentDescription="@null" | ||
| android:src="@drawable/ic_dimagi_logo" /> | ||
|
|
||
| <View | ||
| android:id="@+id/divider" | ||
| android:layout_width="fill_parent" | ||
| android:layout_height="1dp" | ||
| android:layout_marginHorizontal="20dp" | ||
| android:layout_marginTop="40dp" | ||
| android:background="@color/connect_light_grey" /> | ||
|
|
||
| <TextView | ||
| android:id="@+id/connect_primary_phone_title" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="start" | ||
| android:layout_marginStart="16dp" | ||
| android:layout_marginTop="16dp" | ||
| android:layout_marginEnd="16dp" | ||
| android:text="@string/connect_phone_title_primary" | ||
| android:textColor="@color/connect_blue_color" | ||
| android:textSize="16sp" | ||
| android:textStyle="bold"/> | ||
|
|
||
| <TextView | ||
| android:id="@+id/connect_primary_phone_message" | ||
| android:layout_width="fill_parent" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginStart="16dp" | ||
| android:layout_marginTop="8dp" | ||
| android:layout_marginEnd="16dp" | ||
| android:gravity="start" | ||
| android:text="@string/connect_phone_message_primary" | ||
| android:textColor="@color/connect_subtext" | ||
| android:textSize="14sp" | ||
| android:textStyle="bold"/> | ||
|
|
||
| <LinearLayout | ||
| android:id="@+id/phone_layout" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginHorizontal="16dp" | ||
| android:layout_marginTop="16dp" | ||
| android:orientation="horizontal"> | ||
|
|
||
| <LinearLayout | ||
| android:layout_width="42dp" | ||
| android:layout_height="42dp" | ||
| android:background="@drawable/connect_side_icon_bg" | ||
| android:gravity="center"> | ||
|
|
||
| <ImageView | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:contentDescription="@null" | ||
| android:padding="1dp" | ||
| android:src="@drawable/ic_outline_phone_24" /> | ||
|
|
||
| </LinearLayout> | ||
|
|
||
| <LinearLayout | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:orientation="vertical"> | ||
|
|
||
| <LinearLayout | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginStart="16dp" | ||
| android:background="@drawable/connect_edit_text_bg" | ||
| android:padding="0dp"> | ||
|
|
||
| <EditText | ||
| android:id="@+id/countryCode" | ||
| android:layout_width="64dp" | ||
| android:layout_height="55dp" | ||
| android:background="@null" | ||
| android:gravity="center" | ||
| android:hint="@string/connect_phone_country_code_default" | ||
| android:inputType="number" | ||
| android:text="@string/connect_phone_country_code_default" | ||
| android:textColorHint="@color/connect_grey" /> | ||
|
|
||
| <View | ||
| android:layout_width="1dp" | ||
| android:layout_height="match_parent" | ||
| android:layout_marginVertical="10dp" | ||
| android:background="@color/connect_blue_color_10" /> | ||
|
|
||
| <AutoCompleteTextView | ||
| android:id="@+id/connect_primary_phone_input" | ||
| android:layout_width="fill_parent" | ||
| android:layout_height="55dp" | ||
| android:background="@null" | ||
| android:digits="1234567890" | ||
| android:focusable="true" | ||
| android:focusableInTouchMode="true" | ||
| android:hint="@string/connect_phone_number_hint" | ||
| android:inputType="numberDecimal" | ||
| android:paddingLeft="16dp" | ||
| android:textAlignment="textStart" | ||
| android:textColorHint="@color/connect_grey" /> | ||
| </LinearLayout> | ||
|
|
||
| <TextView | ||
| android:id="@+id/errorTextView" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:paddingStart="16dp" | ||
| android:paddingTop="4dp" | ||
| android:textSize="14sp" | ||
| android:textColor="@android:color/holo_red_light" | ||
| android:visibility="gone" | ||
| android:textStyle="bold"/> | ||
| </LinearLayout> | ||
|
|
||
|
|
||
| </LinearLayout> | ||
|
|
||
| <TextView | ||
| android:id="@+id/connect_primary_phone_availability" | ||
| android:layout_width="fill_parent" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginStart="16dp" | ||
| android:layout_marginTop="16dp" | ||
| android:layout_marginEnd="16dp" | ||
| android:gravity="start" | ||
| android:textColor="@color/connect_subtext" | ||
| android:textSize="16sp" | ||
| android:textStyle="bold"/> | ||
|
|
||
| <com.google.android.material.button.MaterialButton | ||
| android:id="@+id/connect_primary_phone_button" | ||
| android:layout_width="120dp" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="end" | ||
| android:layout_marginTop="16dp" | ||
| android:layout_marginEnd="16dp" | ||
| android:text="@string/connect_phone_button" /> | ||
| </LinearLayout> | ||
|
|
||
| </layout> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
ll_recoveris only bottom-constrained – add start/end constraints for RTL safetyWithout start/end constraints the view relies on
match_parentwidth, which is acceptable but discouraged because RTL mirroring can break the position. Add explicit constraints:<LinearLayout android:id="@+id/ll_recover" android:layout_width="match_parent" android:orientation="vertical" app:layout_constraintBottom_toBottomOf="parent" + app:layout_constraintStart_toStartOf="parent" + app:layout_constraintEnd_toEndOf="parent" android:layout_height="wrap_content">🤖 Prompt for AI Agents (early access)