Using CommCare BuildConfig

[OrangeAndGreen]

Technical Summary

Using CommCare BuildConfig instead of Firebase for reporting build number in analytics events.
Old code was reporting -1, and then broke the build recently.

Feature Flag

None

Safety Assurance

Safety story

Simple change, not visible to user but will improve our reporting

Automated test coverage

None

QA Plan

None

Labels and Review

• Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
• Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[coderabbitai]

📝 Walkthrough

Walkthrough

The change updates the import statement for the BuildConfig class in the FirebaseAnalyticsUtil.java file. The import now references org.commcare.dalvik.BuildConfig instead of com.google.firebase.BuildConfig. This change ensures that the build configuration constants used within the analytics utility are sourced from the correct module. No other code or logic in the file was modified.

Suggested labels

product/invisible

Suggested reviewers

• shubham1g5

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0e1553a and dada214.

📒 Files selected for processing (1)

• app/src/org/commcare/google/services/analytics/FirebaseAnalyticsUtil.java (1 hunks)

🔇 Additional comments (2)

app/src/org/commcare/google/services/analytics/FirebaseAnalyticsUtil.java (2)

23-23: Correctly reference CommCare BuildConfig
Switching the import to org.commcare.dalvik.BuildConfig ensures that BuildConfig.VERSION_CODE points to the proper CommCare build configuration (not Firebase), resolving the broken -1 build number in analytics.

---

76-76:

Details

✅ Verification successful

Verify BuildConfig.VERSION_CODE availability
Ensure that VERSION_CODE is defined in org.commcare.dalvik.BuildConfig for all build variants and that there are no lingering imports of com.google.firebase.BuildConfig.

---

🏁 Script executed:

#!/bin/bash
# Check for stale Firebase BuildConfig imports
rg -n "import com\.google\.firebase\.BuildConfig" app/src

# Confirm BuildConfig.VERSION_CODE usage
rg -n "BuildConfig\.VERSION_CODE" app/src

Length of output: 555

---

No stale BuildConfig imports; BUILD_NUMBER property is correctly referenced

• Verified there are no import com.google.firebase.BuildConfig statements in app/src.
• Confirmed BuildConfig.VERSION_CODE is used in both FirebaseAnalyticsUtil.java and AppUtils.java, indicating it’s defined for all build variants.

No further changes required.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.