Additional delivery progress tweak

[OrangeAndGreen]

https://dimagi.atlassian.net/browse/QA-7609?linkSource=email

Product Description

Small additional change to make sure "today" and "tomorrow" are used properly when reporting time remaining near the end of the opportunity.

Technical Summary

This change is about making sure we report 0 days remaining when the end date has passed, 1 day remaining when today is the last day, and 2 days remaining when tomorrow is the last day. Mostly, it's about dealing with the fact that the end date doesn't include a time (so it defaults to 00:00).

Feature Flag

Connect

Safety Assurance

Safety story

Simple math change.

Automated test coverage

None

QA Plan

QA already aware of and testing for this.

Labels and Review

• Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
• Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update the logic in the getDaysRemaining method of the ConnectJobRecord class. The comments have been rephrased for clarity, and an additional comment now explains the inclusion of 86399999 milliseconds (one millisecond less than 24 hours) in the calculation. This adjustment ensures that a project remains valid until midnight of its end date. The method’s return statement is modified to check if the adjusted millis is greater than or equal to zero; if not, it returns 0, indicating no days remaining. There are no changes to the declarations of public or exported entities.

Sequence Diagram(s)

sequenceDiagram
    participant U as Caller
    participant J as ConnectJobRecord
    U->>J: getDaysRemaining()
    activate J
    J->>J: Calculate millis (end date diff + 86399999)
    alt millis ≥ 0
        J-->>U: Return calculated days
    else
        J-->>U: Return 0
    end
    deactivate J

Loading

Possibly related PRs

• Additional tweaks to delivery progress text #3010: Modifications address similar time-sensitive text updates and the calculation for remaining days, enhancing time-related information handling.
• Changes to delivery progress text for each payment unit #3007: Directly connected through a call to getDaysRemaining from the setDeliveriesData method in the delivery progress module.

Suggested labels

cross requested

Suggested reviewers

• pm-dimagi
• avazirna
• Jignesh-dimagi
• shubham1g5

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3704c58 and c65b8e3.

📒 Files selected for processing (1)

• app/src/org/commcare/android/database/connect/models/ConnectJobRecord.java (1 hunks)

🔇 Additional comments (1)

app/src/org/commcare/android/database/connect/models/ConnectJobRecord.java (1)

437-444: Improved deadline calculation logic

The changes address the correct reporting of days remaining by adding 86399999 milliseconds (just under 24 hours) to account for the end date being valid until midnight. The condition change from days >= 0 to millis >= 0 provides more precise handling of edge cases.

This implementation now properly:

• Reports 0 days remaining when the end date has passed
• Reports 1 day remaining when today is the last day
• Reports 2 days remaining when tomorrow is the last day

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.