Pm beta Relase 468048

[pm-dimagi]

Beta Release with swahailli translation

cross-request: dimagi/commcare-core#1465

Technical Summary

Feature Flag

Safety Assurance

Safety story

Automated test coverage

QA Plan

Labels and Review

• Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
• Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[pm-dimagi]

@damagatchi retest this please

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request implements a series of updates across UI layouts, string resources, and authentication/error handling logic. The XML layout files for connection delivery details and sign-up screens have been restructured to use ConstraintLayout instead of legacy layouts. String resources in multiple languages have been corrected to properly represent HTML entities for the XML manifest error messages. In the Java code, changes include enhanced error logging for authentication failures in activities and services by checking for failed ConnectID authentication. In addition, several fragments now use a menu system with MenuProvider to handle sync actions, and the biometric authentication methods have been refactored to consolidate PIN and biometric verification. A new helper method in the ConnectManager centralizes checking for failed ConnectID auth.

Sequence Diagram(s)

sequenceDiagram
    participant LA as LoginActivity
    participant CM as ConnectManager
    participant L as Logger
    LA->>LA: handlePullTaskResult(AUTH_FAILED)
    LA->>CM: checkForFailedConnectIdAuth(username)
    alt ConnectID Auth Failed
        CM-->>LA: true
        LA->>L: Logger.exception("Token auth error for ConnectID managed app")
    else
        CM-->>LA: false
        LA->>LA: Show bad credentials error
    end

Loading

sequenceDiagram
    participant U as User
    participant F as Connect Fragment
    participant MP as MenuProvider
    U->>F: Open menu and select "Sync"
    F->>MP: onMenuItemSelected(MenuItem Sync)
    MP->>F: Trigger refreshData()

Loading

sequenceDiagram
    participant A as Activity
    participant BH as BiometricsHelper
    participant U as User
    A->>BH: authenticateFingerprint(...)
    BH->>BH: authenticatePinOrBiometric(...)
    BH->>U: Display biometric/PIN prompt
    U-->>BH: Provide credentials
    BH->>A: Return authentication result

Loading

Possibly related PRs

• Solved smaller screens UI issues #2980: Involves a similar transition in fragment_connect_delivery_details.xml from legacy layouts to ConstraintLayout with updated layout parameters.
• Delivery Progress UI fix #2989: Updates the ConnectDeliveryProgressFragment layout and refresh logic using menu providers, closely aligning with the current fragment menu refactoring.
• -rounded button issue resolved #2932: Focuses on UI component updates, including the replacement of RoundedButton with MaterialButton, which reflects similar changes in the layout modifications of this PR.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 6

🧹 Nitpick comments (9)

app/res/values-ti/strings.xml (1)

211-211: Correct HTML Entity for Root Element Error in Tigrinya Resource.
The root_element_error string now correctly uses the proper HTML entity <manifest\> instead of an incorrect encoding. This change will ensure that the error message displays the intended XML tag correctly in the UI.

app/src/org/commcare/fragments/connectId/ConnectIdPhoneVerificationFragmnet.java (1)

1-1: File name contains a typo.

The file name "ConnectIdPhoneVerificationFragmnet.java" has a typo - "Fragmnet" should be "Fragment".

Consider renaming the file to correct the spelling:

-ConnectIdPhoneVerificationFragmnet.java
+ConnectIdPhoneVerificationFragment.java

This would require updating all references to this class throughout the codebase.

app/res/layout/fragment_connect_delivery_details.xml (1)

158-190: Good migration to ConstraintLayout, but mixing deprecated attributes

The refactoring from LinearLayout to ConstraintLayout improves layout flexibility and performance. However, the implementation mixes constraint-based positioning with the deprecated android:layout_marginRight attribute.

Consider using android:layout_marginEnd instead of android:layout_marginRight to align with RTL support best practices:

-                            android:layout_marginRight="2dp"
+                            android:layout_marginEnd="2dp"

app/src/org/commcare/utils/BiometricsHelper.java (1)

86-99: Well-implemented consolidated authentication method

The new authenticatePinOrBiometric method effectively handles both authentication methods in a single place, following the DRY principle.

Consider adding a log message or exception handling for the case when neither PIN nor fingerprint is configured, to improve debugging capabilities.

app/res/layout/fragment_signup.xml (4)

27-33: Remove unnecessary orientation attribute from ScrollView

The ScrollView element has an "orientation" attribute which doesn't apply to ScrollViews (only to LinearLayouts). ScrollView only supports vertical scrolling by default.

<ScrollView
    android:id="@+id/firstLayout"
    android:layout_width="match_parent"
    android:layout_height="0dp"
    app:layout_constraintTop_toBottomOf="@+id/llTopBar"
    app:layout_constraintBottom_toTopOf="@+id/ll_recover"
-   android:orientation="vertical">
+   >

---

153-162: Add textColor attribute to countryCode field for better accessibility

The country code field has textColorHint set but lacks a textColor attribute, which could create contrast issues for accessibility. Adding the textColor attribute would improve readability.

<EditText
    android:id="@+id/countryCode"
    android:layout_width="64dp"
    android:layout_height="55dp"
    android:background="@null"
    android:gravity="center"
    android:hint="@string/connect_phone_country_code_default"
    android:inputType="number"
    android:text="@string/connect_phone_country_code_default"
+   android:textColor="@color/connect_dark_blue_color"
    android:textColorHint="@color/connect_grey" />

---

208-217: Add contentDescription for consent checkbox to improve accessibility

The consent checkbox should have a contentDescription attribute to make it accessible to screen readers.

<CheckBox
    android:id="@+id/connect_consent_check"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_marginStart="16dp"
    android:layout_marginBottom="16dp"
    android:buttonTint="@color/connect_blue_color"
    android:padding="1dp"
    android:textColor="@color/connect_subtext"
+   android:contentDescription="@string/connect_consent_message_1"
    android:textSize="13sp" />

---

229-240: Add contentDescription for the continue button

The continue button would benefit from a contentDescription that clearly describes its action, improving accessibility for screen readers.

<com.google.android.material.button.MaterialButton
    android:id="@+id/continue_button"
    style="@style/CustomButtonStyle"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_gravity="end"
    android:layout_marginTop="16dp"
    android:layout_marginEnd="16dp"
    android:gravity="start|center"
    android:text="@string/review"
    android:drawableRight="@drawable/connect_right_arrow"
+   android:contentDescription="@string/review"
    />

app/src/org/commcare/fragments/connect/ConnectDeliveryProgressFragment.java (1)

375-383: Consider using an interface for refreshable fragments

The current implementation uses instanceof checks, which creates tight coupling with specific fragment implementations. Consider defining an interface for refreshable fragments to make this more flexible and maintainable.

// Suggested new interface
+interface RefreshableFragment {
+    void updateView();
+}

// Then modify your fragments to implement this interface
+public class ConnectDeliveryProgressDeliveryFragment extends Fragment implements RefreshableFragment {
+    // Existing code...
+}

// And simplify your refresh method
public void refresh() {
-    for (Fragment fragment : fragmentList) {
-        if (fragment instanceof ConnectDeliveryProgressDeliveryFragment) {
-            ((ConnectDeliveryProgressDeliveryFragment) fragment).updateView();
-        } else if (fragment instanceof ConnectResultsSummaryListFragment) {
-            ((ConnectResultsSummaryListFragment) fragment).updateView();
-        }
-    }
+    for (Fragment fragment : fragmentList) {
+        if (fragment instanceof RefreshableFragment) {
+            ((RefreshableFragment) fragment).updateView();
+        }
+    }
}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cdc7b40 and fbd756c.

📒 Files selected for processing (23)

• app/res/layout/fragment_connect_delivery_details.xml (2 hunks)
• app/res/layout/fragment_signup.xml (2 hunks)
• app/res/values-es/strings.xml (1 hunks)
• app/res/values-fr/strings.xml (1 hunks)
• app/res/values-lt/strings.xml (1 hunks)
• app/res/values-no/strings.xml (1 hunks)
• app/res/values-pt/strings.xml (1 hunks)
• app/res/values-sw/strings.xml (1 hunks)
• app/res/values-ti/strings.xml (1 hunks)
• app/src/org/commcare/activities/LoginActivity.java (1 hunks)
• app/src/org/commcare/activities/SyncCapableCommCareActivity.java (2 hunks)
• app/src/org/commcare/activities/connect/ConnectActivity.java (1 hunks)
• app/src/org/commcare/connect/ConnectDatabaseHelper.java (1 hunks)
• app/src/org/commcare/connect/ConnectManager.java (2 hunks)
• app/src/org/commcare/fragments/connect/ConnectDeliveryProgressFragment.java (6 hunks)
• app/src/org/commcare/fragments/connect/ConnectJobsListsFragment.java (2 hunks)
• app/src/org/commcare/fragments/connect/ConnectLearningProgressFragment.java (3 hunks)
• app/src/org/commcare/fragments/connectId/ConnectIdBiometricConfigFragment.java (1 hunks)
• app/src/org/commcare/fragments/connectId/ConnectIdPhoneVerificationFragmnet.java (1 hunks)
• app/src/org/commcare/fragments/connectId/ConnectIdUserDeactivateOTPVerificationFragment.java (0 hunks)
• app/src/org/commcare/network/CommcareRequestGenerator.java (1 hunks)
• app/src/org/commcare/services/CommCareFirebaseMessagingService.java (3 hunks)
• app/src/org/commcare/utils/BiometricsHelper.java (2 hunks)

💤 Files with no reviewable changes (1)

• app/src/org/commcare/fragments/connectId/ConnectIdUserDeactivateOTPVerificationFragment.java

🧰 Additional context used

🧠 Learnings (1)

app/src/org/commcare/fragments/connectId/ConnectIdBiometricConfigFragment.java (2)

Learnt from: pm-dimagi
PR: dimagi/commcare-android#2949
File: app/src/org/commcare/fragments/connectId/ConnectIdBiometricConfigFragment.java:95-131
Timestamp: 2025-03-31T08:25:14.284Z
Learning: Biometric authentication security improvements were considered but skipped in PR #2949 as per user's request. The implementation remained with basic biometric authentication without additional security layers.

Learnt from: pm-dimagi
PR: dimagi/commcare-android#2949
File: app/src/org/commcare/fragments/connectId/ConnectIdBiometricConfigFragment.java:235-236
Timestamp: 2025-03-31T08:25:14.284Z
Learning: The empty performPasswordUnlock method in ConnectIdBiometricConfigFragment is intentionally left empty and should not be flagged in reviews.

🧬 Code Definitions (5)

app/src/org/commcare/activities/SyncCapableCommCareActivity.java (1)

app/src/org/commcare/connect/ConnectManager.java (1)

• ConnectManager (81-1059)

app/src/org/commcare/network/CommcareRequestGenerator.java (1)

app/src/org/commcare/connect/ConnectManager.java (1)

• ConnectManager (81-1059)

app/src/org/commcare/activities/LoginActivity.java (1)

app/src/org/commcare/connect/ConnectManager.java (1)

• ConnectManager (81-1059)

app/src/org/commcare/fragments/connectId/ConnectIdBiometricConfigFragment.java (1)

app/src/org/commcare/utils/BiometricsHelper.java (1)

• BiometricsHelper (25-164)

app/src/org/commcare/connect/ConnectManager.java (2)

app/src/org/commcare/utils/BiometricsHelper.java (1)

• BiometricsHelper (25-164)

app/src/org/commcare/connect/ConnectDatabaseHelper.java (1)

• ConnectDatabaseHelper (56-1024)

🔇 Additional comments (28)

app/res/values-es/strings.xml (1)

151-151: Fix HTML Entity Representation in Spanish Resource.
The root_element_error string has been updated from an incorrect HTML entity to the proper format <manifest\>, ensuring the error message now accurately shows the expected XML root element for Spanish-speaking users.

app/res/values-no/strings.xml (1)

152-152: Update Root Element Error Formatting in Norwegian Resource.
The root_element_error string now correctly displays <manifest> using <manifest\> instead of a mis-encoded value. This adjustment ensures consistency with the changes made in other language files and guarantees proper rendering in the application.

app/res/values-fr/strings.xml (1)

151-151: Corrected HTML entity encoding for proper display of XML tags

The change properly fixes the double encoding issue where < (which would render as <) is replaced with the correct HTML entity < for the less-than symbol. This ensures that error messages about manifest files will display correctly to French-speaking users.

app/res/values-lt/strings.xml (1)

152-152: Corrected HTML entity encoding in Lithuanian string resource

Similar to the French translation, this change fixes the double encoding issue with HTML entities by replacing < with the correct < representation for the less-than symbol in the error message.

app/src/org/commcare/activities/SyncCapableCommCareActivity.java (2)

33-33: Added import for Logger class

Added import for the Logger class that will be used for enhanced error reporting of authentication failures.

---

109-112: Enhanced error logging for ConnectID authentication failures

Added specific error handling for ConnectID authentication failures during sync operations. This will help with debugging and monitoring of authentication issues by explicitly logging when token authentication fails for a ConnectID managed app.

The implementation properly leverages the checkForFailedConnectIdAuth helper method from ConnectManager to detect ConnectID authentication failures.

app/res/values-pt/strings.xml (1)

223-223: Fixed XML tag encoding in Portuguese error message

This change properly escapes the greater-than symbol (>) in the XML string resource by using \> instead of a plain >. This ensures the error message correctly displays the XML tag notation <manifest> rather than interpreting it as actual XML markup.

app/src/org/commcare/services/CommCareFirebaseMessagingService.java (3)

18-18: LGTM - Adding utility import for string validation.

This import allows using the Strings.isEmptyOrWhitespace method for validating notification content.

---

221-224: Good enhancement to log empty push notifications.

Adding validation to check for empty or whitespace-only notifications improves error detection and troubleshooting. This change helps identify situations where FCM delivers notifications without meaningful content.

---

236-236: LGTM - Improved code formatting.

This formatting change improves code consistency and readability.

app/src/org/commcare/connect/ConnectDatabaseHelper.java (1)

345-348: Good enhancement to prevent status regression.

This change ensures that job statuses don't move backward when synchronizing with the server. By preserving the higher status value, you avoid potential state inconsistencies when the app has transitioned a job to a more advanced state than the server knows about.

app/src/org/commcare/fragments/connectId/ConnectIdPhoneVerificationFragmnet.java (1)

244-244: Security improvement for Android 13+ broadcast receiver registration.

Updating the version check from Oreo to Tiramisu ensures proper broadcast receiver security on newer Android versions. For Android 13+, the receiver is registered with the RECEIVER_NOT_EXPORTED flag to comply with the platform's security requirements.

app/src/org/commcare/activities/LoginActivity.java (1)

881-884: Improved error logging for ConnectID authentication failures.

This enhancement adds specific logging when authentication fails for a ConnectID managed application. The additional context helps identify and troubleshoot token-related authentication issues by distinguishing between regular login failures and those related to ConnectID management.

app/src/org/commcare/fragments/connectId/ConnectIdBiometricConfigFragment.java (1)

237-239: Method call updated to use simplified interface.

The change simplifies the fingerprint authentication call by removing the allowOtherOptions parameter, aligning with the refactored implementation in BiometricsHelper. This is part of a larger consolidation of PIN and biometric authentication logic into the authenticatePinOrBiometric method.

The new implementation maintains the same functionality while streamlining the authentication process.

app/src/org/commcare/activities/connect/ConnectActivity.java (1)

184-184: Menu handling refactored to use MenuProviders in fragments.

This comment replaces code that previously called getCurrentFragment().onOptionsItemSelected(item), indicating a shift from centralized menu handling in the activity to distributed handling in individual fragments via MenuProvider. This architectural change improves modularity and aligns with modern Android development practices.

The getCurrentFragment() method has also been removed as it's no longer needed with this new approach.

app/src/org/commcare/fragments/connect/ConnectLearningProgressFragment.java (3)

5-7: Added imports for menu handling.

These imports support the new menu handling mechanism being implemented in this fragment.

---

29-35: Updated imports to support MenuProvider implementation.

These additional imports support the MenuProvider pattern for handling menu actions at the fragment level.

---

84-101: Implemented MenuProvider for decentralized menu handling.

The fragment now directly handles its own menu actions through a MenuProvider implementation. When the sync action is selected, it calls refreshData() to update the fragment's data.

This change is part of a larger architectural improvement that shifts menu handling responsibility from the activity to individual fragments, making the code more modular and maintainable.

app/src/org/commcare/connect/ConnectManager.java (2)

249-249: Updated authenticateFingerprint call to match new method signature.

The method call has been simplified by removing the allowOtherOptions parameter, matching the refactored method signature in BiometricsHelper. This is part of a consolidation effort to streamline biometric authentication.

---

568-581: Added helper method to check for failed ConnectID authentication.

This new method centralizes the logic for checking if a worker's ConnectID authentication has failed. It:

1. Verifies if ConnectID is configured
2. Retrieves the application record for the current user
3. Checks if the worker is linked
4. Includes proper exception handling to log errors

This addition enhances error handling capabilities for authentication failures across the application, particularly in login activities and network request generation.

app/src/org/commcare/fragments/connect/ConnectJobsListsFragment.java (1)

105-121: Good modernization of menu handling using MenuProvider

The implementation now uses the recommended approach for fragment menu handling with MenuHost and MenuProvider. This properly associates menu interactions with the fragment's lifecycle and follows current Android best practices.

app/src/org/commcare/network/CommcareRequestGenerator.java (1)

186-189: Good refactoring of ConnectID auth failure checks

Moving the ConnectID authentication failure check to a centralized method in ConnectManager improves code organization and maintainability.

app/src/org/commcare/utils/BiometricsHelper.java (2)

53-53: Good simplification of fingerprint authentication method

Refactoring to use the consolidated authentication method streamlines the code and reduces duplication.

---

82-84: Good consolidation of PIN authentication

Redirecting to the common authentication method reduces code duplication and simplifies maintenance.

app/res/layout/fragment_signup.xml (2)

3-7: Good improvement using ConstraintLayout instead of FrameLayout

The switch to ConstraintLayout offers better positioning control and responsiveness compared to the previous FrameLayout implementation.

---

11-24: Good use of layout reuse with include tag

The implementation of a common app bar through the include tag promotes code reuse and consistency across the application.

app/src/org/commcare/fragments/connect/ConnectDeliveryProgressFragment.java (2)

172-188: Great implementation of MenuProvider for menu handling

Using MenuProvider and attaching it to the fragment's view lifecycle is the modern and recommended approach for handling menus in fragments. This ensures proper lifecycle management and separation of concerns.

---

356-373: Good refactoring of ViewStateAdapter to use a list

Changing from static fragment references to a list-based approach makes the code more maintainable and flexible. It will be easier to add or modify fragment types in the future.

[coderabbitai]

🛠️ Refactor suggestion

Remove redundant onOptionsItemSelected method

This method is redundant since you're already handling menu selections through the MenuProvider implementation above. Having both can lead to confusion or duplicated behavior. The MenuProvider approach is preferred in modern Android development.

-@Override
-public boolean onOptionsItemSelected(MenuItem item) {
-    if(item.getItemId() == R.id.action_sync) {
-        refreshData();
-        return true;
-    }
-
-    return false;
-}

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	@Override
	public boolean onOptionsItemSelected(MenuItem item) {
	if(item.getItemId() == R.id.action_sync) {
	refreshData();
	return true;
	}
	return false;
	}

[coderabbitai]

⚠️ Potential issue

Fix quote escaping in multiple string resources

There are several strings with improper quote escaping that could cause XML parsing issues. The pattern \"?" appears to be incorrect - it should be either \"?\" (if the question mark is part of the text) or just \"? (if the question mark is followed by the end of the string).

-<string name="clearanswer_confirm">Ondoa jibu kwa \%s\"?"</string>
+<string name="clearanswer_confirm">Ondoa jibu kwa \%s\"?</string>

-<string name="download_failed_with_error">Fomu \%1$s\" haikufaulu. %2$s."</string>
+<string name="download_failed_with_error">Fomu \%1$s\" haikufaulu. %2$s.</string>

-<string name="enter_data_description">Uko mwanzoni mwa \%s\". Telezesha kidole skrini kama inavyoonyeshwa hapa chini ili kuanza."</string>
+<string name="enter_data_description">Uko mwanzoni mwa \%s\". Telezesha kidole skrini kama inavyoonyeshwa hapa chini ili kuanza.</string>

Also applies to: 119-119, 126-126

[coderabbitai]

⚠️ Potential issue

Fix improperly escaped quote in string resource

There's an issue with the closing quotes in this string resource. The double quotes at the end appear to be a mistake or improperly formatted.

-<string name="back_to_manager">Rudi kwa Kidhibiti Programu""</string>
+<string name="back_to_manager">Rudi kwa Kidhibiti Programu</string>

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	<string name="back_to_manager">Rudi kwa Kidhibiti Programu""</string>
	<string name="back_to_manager">Rudi kwa Kidhibiti Programu</string>

[coderabbitai]

💡 Verification agent

🧩 Analysis chain

Verify all string resources for proper XML escaping

While adding Swahili translations is valuable, I've identified several XML escaping issues in the strings. It's recommended to perform a thorough review of all strings to ensure:

1. Proper escaping of quotes (\")
2. Correct XML attribute closing
3. Valid string formatting placeholders
4. Proper handling of escape sequences

Consider using automated tools to validate the XML structure of the strings.xml file.

---

🏁 Script executed:

#!/bin/bash
# Check for potential XML escaping issues in the strings.xml file

echo "Checking for potentially problematic escape sequences in strings.xml"
grep -n '\\[^ntr\"%]' app/res/values-sw/strings.xml
echo "Checking for quotes that might not be properly escaped"
grep -n '"[^<]' app/res/values-sw/strings.xml
echo "Checking for potentially malformed string format patterns"
grep -n '%[^s0-9d]' app/res/values-sw/strings.xml

Length of output: 58462

---

Fix XML Escaping Issues in Swahili Translations

Several XML formatting problems were detected that need to be resolved before merging. In particular:

• Invalid Escape Sequences:
 – Several strings (e.g., line 85 “advance”: sambaza kwa\inayofuata\nmoja) include invalid escape sequences (like \i) that must be fixed.
 – Unnecessary use of backslashes before single quotes (e.g., in “migration_possible_failure” and “privilege_instructions”) should be removed unless absolutely needed.

• Incorrect XML Entity Escaping:
 – The “root_element_error” string shows <manifest\> where the extraneous backslash before > should be removed.
 – In the CCZ error messages (lines 316 and 317), the phrases \Chagua CCZ\" need to be corrected to properly quote the text (e.g., use "Chagua CCZ" without backslashes).

• Misplaced or Extra Quotes:
 – The “back_to_manager” string contains an extra ending quote that should be removed.

• String Formatting Patterns:
 – Verify that all formatting specifiers (e.g., those in “about_dialog”) are correctly defined and that no superfluous symbols are present.

It’s recommended to run an XML validator or use automated tools to scan all string resources in this file once the above fixes are implemented.

[coderabbitai]

⚠️ Potential issue

Fix quote escaping in about_dialog string

There are improperly escaped quotes in this string that could cause XML parsing issues:

1. The quote after "Orodha" should be escaped
2. The ending quote appears to be part of the value rather than correctly closing the XML attribute

-<string name="about_dialog">%. \n* Ishara ya "Penseli" kwa Creologica \n* ishara ya "Daftari" na Carlo \n* ishara ya "Antena" kwa Dima \n* ishara ya "Alama ya Ramani" na P.J. Onori \n* Orodha" ya Landan Lloyd \n* skrini iliyovunjwa na Sam Martin kutoka kwa Nomino Project \n\n\n\n"</string>
+<string name="about_dialog">%. \n* Ishara ya \"Penseli\" kwa Creologica \n* ishara ya \"Daftari\" na Carlo \n* ishara ya \"Antena\" kwa Dima \n* ishara ya \"Alama ya Ramani\" na P.J. Onori \n* Orodha\" ya Landan Lloyd \n* skrini iliyovunjwa na Sam Martin kutoka kwa Nomino Project \n\n\n\n</string>

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	<string name="about_dialog">%. \n* Ishara ya "Penseli" kwa Creologica \n* ishara ya "Daftari" na Carlo \n* ishara ya "Antena" kwa Dima \n* ishara ya "Alama ya Ramani" na P.J. Onori \n* Orodha" ya Landan Lloyd \n* skrini iliyovunjwa na Sam Martin kutoka kwa Nomino Project \n\n\n\n"</string>
	<string name="about_dialog">%. \n* Ishara ya \"Penseli\" kwa Creologica \n* ishara ya \"Daftari\" na Carlo \n* ishara ya \"Antena\" kwa Dima \n* ishara ya \"Alama ya Ramani\" na P.J. Onori \n* Orodha\" ya Landan Lloyd \n* skrini iliyovunjwa na Sam Martin kutoka kwa Nomino Project \n\n\n\n</string>

[coderabbitai]

⚠️ Potential issue

Fix invalid escape sequence in string resources

There are invalid escape sequences in these strings. The backslash before "Chagua CCZ" is not properly escaped, which could cause display or parsing issues.

-<string name="recovery_measure_ccz_scan_failed">Hitilafu ilitokea wakati wa kupakua faili ya CCZ kwenye simu yako. Tafadhali jaribu tena au tafuta faili ya CCZ wewe mwenyewe kwa kubofya kitufe cha \Chagua CCZ\" hapa chini."</string>
+<string name="recovery_measure_ccz_scan_failed">Hitilafu ilitokea wakati wa kupakua faili ya CCZ kwenye simu yako. Tafadhali jaribu tena au tafuta faili ya CCZ wewe mwenyewe kwa kubofya kitufe cha \"Chagua CCZ\" hapa chini.</string>

-<string name="recovery_measure_unzip_error">Hitilafu imetokea wakati wa kusakinisha programu kutoka kwa faili ya CCZ. Tafadhali jaribu tena au tafuta faili ya CCZ wewe mwenyewe kwa kubofya kitufe cha \Chagua CCZ\" hapa chini."</string>
+<string name="recovery_measure_unzip_error">Hitilafu imetokea wakati wa kusakinisha programu kutoka kwa faili ya CCZ. Tafadhali jaribu tena au tafuta faili ya CCZ wewe mwenyewe kwa kubofya kitufe cha \"Chagua CCZ\" hapa chini.</string>

Committable suggestion skipped: line range outside the PR's diff.

[shubham1g5]

Closing this as this should no longer be needed.