-
-
Notifications
You must be signed in to change notification settings - Fork 45
Update Firebase dependencies #3002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis pull request updates the Firebase dependency versions in the Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
shubham1g5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should verify that we get crashes and analytics events with this update.
Product Description
This PR is to update Firebase Analytics and Crashlytics to 20.1.2 and 18.3.7, respectively. The main motivation is to make ANRs available in Crashlytics, this will give better insight into the affected users and domains. Crashlytics started supporting ANR collection in 18.4.2. The Firebase Analytics bump is more opportunistic, the current version is from 2020 and from the release notes, this bump seems safe to make.
Safety Assurance
Safety story
Caused a crash and was able to confirm its report in
Crashlyticsas well as the Analytics events.Labels and Review