Skip to content

Conversation

@avazirna
Copy link
Contributor

@avazirna avazirna commented Mar 27, 2025

Product Description

This PR is to update Firebase Analytics and Crashlytics to 20.1.2 and 18.3.7, respectively. The main motivation is to make ANRs available in Crashlytics, this will give better insight into the affected users and domains. Crashlytics started supporting ANR collection in 18.4.2. The Firebase Analytics bump is more opportunistic, the current version is from 2020 and from the release notes, this bump seems safe to make.

Safety Assurance

Safety story

Caused a crash and was able to confirm its report in Crashlytics as well as the Analytics events.

Labels and Review

  • Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
  • Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@coderabbitai
Copy link

coderabbitai bot commented Mar 27, 2025

📝 Walkthrough

Walkthrough

This pull request updates the Firebase dependency versions in the app/build.gradle file. The version for Firebase Analytics has been upgraded from 17.5.0 to 20.1.2, and the version for Firebase Crashlytics has been updated from 17.2.1 to 18.3.7. These modifications solely focus on dependency updates, without any changes to the application logic, structure, or control flow.

Possibly related PRs

Suggested labels

skip-integration-tests

Suggested reviewers

  • OrangeAndGreen
  • pm-dimagi
  • shubham1g5

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4ed1de0 and ac054fa.

📒 Files selected for processing (1)
  • app/build.gradle (1 hunks)
🔇 Additional comments (2)
app/build.gradle (2)

104-104: Firebase Analytics Dependency Update
The Firebase Analytics version has been updated from 17.5.0 to 20.1.2. Please ensure that any associated API changes or migration steps recommended by Firebase are fully addressed in the rest of the codebase and documentation.


106-106: Firebase Crashlytics Dependency Update
The Firebase Crashlytics version has been updated from 17.2.1 to 18.3.7. Verify that any breaking changes or required migration steps described in the Firebase release notes have been applied. It might also be worth running a smoke test on crash reporting to ensure stability after this upgrade.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@avazirna avazirna requested a review from shubham1g5 March 28, 2025 00:09
Copy link
Contributor

@shubham1g5 shubham1g5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should verify that we get crashes and analytics events with this update.

@avazirna avazirna merged commit 3600813 into commcare_2.56 Mar 31, 2025
2 checks passed
@avazirna avazirna deleted the update-firebase-dependencies branch March 31, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants