Remove directly bundled libraries

[avazirna]

Product Description

When JCenter was sunset, some of our dependencies started failing to resolve. As a temporary solution, we manually added the library files to the project structure. This PR removes those libraries and updates the dependencies according to available repositories.

Safety Assurance

Safety story

Tested locally

Labels and Review

• Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
• Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
• Risk label is set correctly
• The set of people pinged as reviewers is appropriate for the level of risk of the change

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request updates the app/build.gradle file by modifying the dependency configuration and repository source. A new Maven repository is added with the URL https://repository.liferay.com/nexus/content/repositories/public/. Several AAR file dependency implementations previously used for libraries like LibSimprints, mapbox-android-accounts, realm-android-library, volley, and storage have been removed. In their place, the dependency for com.simprints:libsimprints:2024.2.2 is introduced, consolidating the previous implementations. Additionally, two new dependencies have been added: com.android.volley:volley:1.2.1 and com.snatik:storage:2.1.0. The modifications also remove prior exclusions (for mapbox-android-accounts and io.realm) from the Kujaku library configuration. These changes are focused on dependency management and build configuration adjustments.

Suggested reviewers

• pm-dimagi
• shubham1g5

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 934c13f and 7cd97d3.

📒 Files selected for processing (1)

• app/build.gradle (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Lint Code Base

🔇 Additional comments (4)

app/build.gradle (4)

25-25: New Maven Repository Addition: Confirm Repository Priority
The new Maven repository (https://repository.liferay.com/nexus/content/repositories/public/) has been correctly added. Please verify that its placement in the repositories block (after the jitpack repository and the flatDir definition) satisfies your dependency resolution order and does not inadvertently override or conflict with other repositories.

---

74-74: Updated Dependency for LibSimprints
The manually bundled AAR files have been replaced by the Maven dependency com.simprints:libsimprints:2024.2.2. This aligns well with the PR objective to remove directly bundled libraries. Please verify that version 2024.2.2 is fully compatible with the rest of the project.

---

120-121: New Dependencies for Volley and Storage
The explicit dependencies for Volley (com.android.volley:volley:1.2.1) and Storage (com.snatik:storage:2.1.0) have been added. This change replaces the manual inclusion of these libraries. Ensure that these versions are compatible with any transitive dependencies and meet your project's requirements.

---

122-126: Review of Exclusions in the Kujaku Dependency Block
Within the Kujaku configuration, modules 'volley' and 'storage' are still explicitly excluded. Given that you are now adding these dependencies directly, please confirm that these exclusions are intentional—to prevent conflicting transitive dependencies—or if they should be revisited to leverage the new versions.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.