Removed adding Go to connect jobs in dropdown in login screen

[Jignesh-dimagi]

Technical Summary

https://dimagi.atlassian.net/browse/CCCT-712

cross-request: dimagi/commcare-core#1455

Feature Flag

This is bug fix

Automated test coverage

QA Plan

User should login with CommCare account and then move to sign up for connect sign up. After this, move to login page, where duplication of Go to Connect Jobs should not be visible in dropdown.

Labels and Review

Not applicable for this PR.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request updates the populateAppSpinner method in the LoginActivity class by removing the conditional block that checked for a configured Connect ID. Previously, this block determined whether to include a Connect app option in the dropdown by adding its name and unique ID. With this code removed, the method now directly iterates over the readyApps list to populate the dropdown with the display names and unique IDs of the applications, while the overall control flow remains intact.

Suggested reviewers

• pm-dimagi

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b83930b and a8fd824.

📒 Files selected for processing (1)

• app/src/org/commcare/activities/LoginActivity.java (0 hunks)

💤 Files with no reviewable changes (1)

• app/src/org/commcare/activities/LoginActivity.java

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[OrangeAndGreen]

@damagatchi retest this please

[OrangeAndGreen]

This will prevent the menu option from being added and is a good start, but there's a bit more we need to do to get rid of the functionality. Check out the isConnectJobsSelected function (line 763), which should now be deleted and any callers should always assume the false case.

We can also remove the login.app.connect entry from android_translatable_strings.txt, since that string isn't used anymore.

[Jignesh-dimagi]

@OrangeAndGreen Made the changes as per the comment