Minor UI updates #2936
Merged
Minor UI updates #2936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrangeAndGreen
approved these changes
Jan 14, 2025
shubham1g5
reviewed
Jan 15, 2025
| }; | ||
| d.setPositiveButton(StringUtils.getStringRobust(mActivity, R.string.recovery_measure_reinstall_online_method), listener); | ||
| d.setNegativeButton(StringUtils.getStringRobust(mActivity, R.string.recovery_measure_reinstall_offline_method), listener); | ||
| d.setNegativeButton(StringUtils.getStringRobust(mActivity, R.string.recovery_measure_reinstall_offline_method), listener, true); |
Contributor
There was a problem hiding this comment.
curious why was this changed ?
Contributor
Author
There was a problem hiding this comment.
We are now using an outlined button style for negative actions and the Reinstall using CCZ is not a negative action, so this is to change the style of the the negative button:
This is how it looked before:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses some feedback received from the CommCare UI changes done as part of the rebranding campaign. The affected elements are:
FINISHbutton stylePR Checklist
Safety story
Ran tests locally and didn't find any issues. These changes are at the UI level and shouldn't impact any functionality.