Enable Firebase Performance Monitoring #2845
Conversation
|
@damagatchi retest this please |
|
@damagatchi retest this please |
1 similar comment
|
@damagatchi retest this please |
📝 WalkthroughWalkthroughThe changes in this pull request involve the integration of Firebase Performance Monitoring into the application by modifying the Additionally, in the main Sequence Diagram(s)sequenceDiagram
participant Developer
participant BuildSystem
participant Firebase
Developer->>BuildSystem: Add Firebase Performance plugin
Developer->>BuildSystem: Add Firebase Performance dependency
BuildSystem->>Firebase: Integrate Performance Monitoring
Firebase-->>BuildSystem: Performance Monitoring Enabled
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
build.gradle (1)
15-15: Consider upgrading to the latest version of the Firebase Performance plugin.The current version '1.4.2' is outdated. Consider upgrading to the latest version to get important bug fixes and performance improvements.
- classpath 'com.google.firebase:perf-plugin:1.4.2' + classpath 'com.google.firebase:perf-plugin:1.4.2+'app/build.gradle (1)
103-103: Consider upgrading to the latest version of Firebase Performance.The current version '21.0.1' is outdated. Consider upgrading to the latest version for better performance and bug fixes.
- implementation 'com.google.firebase:firebase-perf:21.0.1' + implementation 'com.google.firebase:firebase-perf:21.5.0'
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
app/build.gradle(2 hunks)build.gradle(1 hunks)
🔇 Additional comments (2)
app/build.gradle (2)
18-18: LGTM!
The Firebase Performance plugin is correctly applied after other Firebase plugins.
18-18: Monitor the impact on app size.
Firebase Performance Monitoring can increase your app size. Consider:
- Monitoring the APK size impact after integration
- Using Android Studio's APK Analyzer to compare before/after sizes
- Setting up size monitoring in your CI pipeline
- Using R8/ProGuard optimization rules specific to Firebase Performance
Also applies to: 103-103
|
@damagatchi retest this please |
|
@damagatchi retest this please |
|
@damagatchi retest this please |
avazirna
changed the title
This reverts commit 22b057e.
|
@shubham1g5 this is ready for review |
shubham1g5
left a comment
shubham1g5
left a comment
There was a problem hiding this comment.
@avazirna What are the next steps on the safety story here ? Has this been verified by you or needs to be done ?
gradle.properties
Outdated
|
|
||
| # Set this flag to 'false' to disable @AddTrace annotation processing and automatic monitoring of HTTP/S network | ||
| # requests for all build variants at compile time. | ||
| firebasePerformanceInstrumentationEnabled=false |
There was a problem hiding this comment.
should not this be true ?
There was a problem hiding this comment.
This is a bit confusing, I had to run tests to understand its impact. This property prevents the instrumentation of the app code (basically, to add code to automatically measure the traces) but doesn't disable the SDK, so some traces are still collected and the manual traces work fine. However, the current issue is with the JaCoCo plugin so I will spend some time tweaking its configuration to see if we can use the SDK in full.
This reverts commit 2cbf67d.
|
@damagatchi retest this please |
1 similar comment
|
@damagatchi retest this please |
|
@damagatchi retest this please |
1 similar comment
|
@damagatchi retest this please |
|
@damagatchi retest this please |
Summary
This PR enables Firebase Performance Monitoring for CommCare. This service automatically captures metrics related to the performance of Android apps, such as screen rendering times, network latency, component lifecycle events, and offers the possibility to include custom traces targeting specific app behaviours.
Safety Assurance
Safety story
Considering that this adds a new SDK to the app and runs on its own service, it's important to ensure that it doesn't impact App size and there are no major performance implications.