fix(giscus): add support for strict mapping parameter #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The theme's JavaScript did not read or apply the `strict` parameter from the site config, preventing the use of Giscus's strict mapping feature. On multilingual sites using `pathname` mapping, this default fuzzy matching could cause incorrect discussion mapping. For example, a page at `/about/` could incorrectly load the discussion for a page at `/zh-cn/about/`. This commit resolves the issue by: 1. Ensuring the `strict` parameter is passed from the Hugo template (`comment.html`) to the global config object. 2. Updating `theme.js` to read this `strict` value and set the `data-strict` attribute on the dynamically generated Giscus script tag. This allows users to enable exact matching by setting `strict = "1"` in their config, fixing the multilingual comment issue.
✅ Deploy Preview for hugo-loveit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The theme's JavaScript did not read or apply the
strictparameter from the site config, preventing the use of Giscus's strict mapping feature.On multilingual sites using
pathnamemapping, this default fuzzy matching could cause incorrect discussion mapping. For example, a page at/about/could incorrectly load the discussion for a page at/zh-cn/about/.This commit resolves the issue by:
strictparameter is passed from the Hugo template (comment.html) to the global config object.theme.jsto read thisstrictvalue and set thedata-strictattribute on the dynamically generated Giscus script tag.This allows users to enable exact matching by setting
strict = "1"in their config, fixing the multilingual comment issue.