-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BCP47 parser #2
Conversation
The type that is currently called My proposal is to rename it to [1] https://en.wikipedia.org/wiki/UN_M49 EDIT: this has now been implemented in #3 |
Looks good other than the two comments I made and the |
The You said you wrote two comments but I can't see them? With regards to releasing, I think it's valuable to first decide whether to merge #3 in the next major bump or not |
@miniBill is this the problem that's causing the false positives? sparksp/elm-review-imports#127 I don't like the idea of using suppressed errors for bugs - I try to avoid suppressing errors, I see the main use case for those as being adopting a rule in a large codebase where you can't fix everything at once. I'd rather turn off the rule temporarily with a comment that links to the GitHub issue and explains that it can be re-enabled once that fixed. Would you be up for adding that in this PR?
Good idea, I'll hold off on releasing until we've discussed that. |
I can see them from this page #2. |
(notice how it says "Pending" on top, it means they are not visible to me yet) |
Ah yes, sorry about that, I sent them off for review so should be good now! |
Made the changes requested |
No description provided.