Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BCP47 parser #2

Merged
merged 11 commits into from
Oct 4, 2023
Merged

Add BCP47 parser #2

merged 11 commits into from
Oct 4, 2023

Conversation

miniBill
Copy link
Contributor

No description provided.

@miniBill
Copy link
Contributor Author

miniBill commented Sep 1, 2023

The type that is currently called Country and described as ISO 3166-1 country code is called region in BCP47, because it could also be an UM M49 [1] numeric code.

My proposal is to rename it to Region.

[1] https://en.wikipedia.org/wiki/UN_M49

EDIT: this has now been implemented in #3

@miniBill miniBill mentioned this pull request Sep 15, 2023
@dillonkearns
Copy link
Owner

Looks good other than the two comments I made and the elm-review errors in the CI. I'll merge and release once that's resolved. Thanks for the PR @miniBill!

@miniBill
Copy link
Contributor Author

The NoModuleOnExposedNames errors are false positives, I can suppress them?

You said you wrote two comments but I can't see them?

With regards to releasing, I think it's valuable to first decide whether to merge #3 in the next major bump or not

@dillonkearns
Copy link
Owner

@miniBill is this the problem that's causing the false positives? sparksp/elm-review-imports#127

I don't like the idea of using suppressed errors for bugs - I try to avoid suppressing errors, I see the main use case for those as being adopting a rule in a large codebase where you can't fix everything at once. I'd rather turn off the rule temporarily with a comment that links to the GitHub issue and explains that it can be re-enabled once that fixed. Would you be up for adding that in this PR?

With regards to releasing, I think it's valuable to first decide whether to merge #3 in the next major bump or not

Good idea, I'll hold off on releasing until we've discussed that.

@dillonkearns
Copy link
Owner

You said you wrote two comments but I can't see them?

I can see them from this page #2.

I see the comments like this in that page:
Screenshot 2023-09-27 at 8 13 26 PM

@miniBill
Copy link
Contributor Author

(notice how it says "Pending" on top, it means they are not visible to me yet)
Both comments make sense, will do!

src/LanguageTag/PrivateUse.elm Outdated Show resolved Hide resolved
src/LanguageTag/Parser.elm Show resolved Hide resolved
@dillonkearns
Copy link
Owner

(notice how it says "Pending" on top, it means they are not visible to me yet)

Ah yes, sorry about that, I sent them off for review so should be good now!

@miniBill
Copy link
Contributor Author

Made the changes requested

@dillonkearns dillonkearns merged commit 2b18171 into dillonkearns:main Oct 4, 2023
1 check failed
@dillonkearns
Copy link
Owner

Looks good, thank you for the PR @miniBill!

I'll let you follow up with #3 before I cut a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants