Add Zykov and Christofides Algorithms for Chromatic Number #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanGilligan
force-pushed
the
egilligan-bab-chromatic-number
branch
2 times, most recently
from
4c77fee to
101c55d
Compare
wilfwilson
previously approved these changes
Sep 21, 2021
james-d-mitchell
requested changes
Jan 5, 2022
EwanGilligan
force-pushed
the
egilligan-bab-chromatic-number
branch
4 times, most recently
from
4db0f0c to
0af7fc2
Compare
|
@james-d-mitchell I've made the requested changes based on our discussion yesterday, let me know if you have any further comments. |
|
We should either update this PR and merge it, or close it. |
james-d-mitchell
added
the
gap-days-brussels-2025
Style changes from review Duplicate tests already included Add outline for Byskov algorithm Add function to find three colourable subgraphs Moved three colourable processing to before Byskov Added declaration for Byskovs Handled Special case for three vertices and no maximal independent sets Wasn't actually getting the complement of the independent set Create category isDigraphAlgorithm and sub-category isDigraphColouringAlgorithm Will be used to distinguish different colouring algorithms that are available. Add Bound Global objects for Digraph Colouring Algorithms Update original functions to use new method selection Update test for new method selection Forgot to subtract set before getting the induced subgraph Remove from extreme test as it is far too large for these tests Move tests that are too slow Special case was not needed Add loop checks to Lawler and Byskov Algorithms Remove Extreme Tests Add standard tests that will run in a reasonable amount of time Not all chromatic number tests were duplicated, as some would use too much memory or take too long Fix formatting More formatting issues Should be the last one Added Documentation Misc Comments Make label match docs Optimise away the subdigraph use Remove another copy Fix lawler issues Optimise Byskov clarify todo Revert to using induced subdigraph Fix some linting Missed a few Fix Indent Add method selection objects for Zykov Initial algorithm skeleton Fill in the rest Forgot about edge direction Documentation Start adaptation for pruned trees Simplify logic Add tests for Zykov Add filters and method objects for Christofides Initialise variable for Christofides Update comments Initial version of Christofides implemented. Fixed a few syntax errors Fix calculation of MIS Remove debug print Cleanup christofides fix typo Convert to using Blists Need to benchmark to check improvement Fix formatting Missed some trailing whitespace Restart attempt at in place zykov Revert to just copying In place is more hassle than it's worth Remove redundant extra check Use new function for Christofides Fix merge issues Add vertex ordering to Zykov Add Christofides test Optimise clique finder used Fix lint remove duplicate bib Update for new method selection Fix test output Update Docs Remove unused reference Fix spelling mistake
Add additional explanation to Zykov Improve vertex picking for Zykov Simplify vertex picking for Christofides
james-d-mitchell
force-pushed
the
egilligan-bab-chromatic-number
branch
from
2a8b694 to
9235546
Compare
james-d-mitchell
assigned
james-d-mitchell and
Joseph-Edwards and unassigned
james-d-mitchell
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Zykov and Christofides Algorithms for Chromatic Number. This builds on the previous pull request #382 to add two additional algorithms for calculating the Chromatic Number. These use the same method selection as the existing implementations, and so are simply additional options to use.