Digraphs on windows compiles to .dll and not to .so

[olexandr-konovalov]

I still can not provide a working version of digraphs (and hence semigroups, which needs it) for GAP 4.10.1. It compiles to bin/i686-pc-cygwin-default32-kv3/digraphs.dll while its AvailabilityTest checks for digraphs.so.

Furthermore, this happens if I edit AvailabilityTest to check for digraphs.dll:

gap> LoadPackage("dig");
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Loading  orb 4.8.2 (Methods to enumerate orbits)
by Juergen Mueller (http://www.math.rwth-aachen.de/~Juergen.Mueller),
   Max Neunhöffer (http://www-groups.mcs.st-and.ac.uk/~neunhoef), and
   Felix Noeske (http://www.math.rwth-aachen.de/~Felix.Noeske).
Homepage: https://gap-packages.github.io/orb
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Loading  GRAPE 4.8.1 (GRaph Algorithms using PErmutation groups)
by Leonard H. Soicher (http://www.maths.qmul.ac.uk/~lsoicher/).
Homepage: https://gap-packages.github.io/grape
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Error, Variable: 'IS_MULTI_DIGRAPH' must have a value
not in any function at /proc/cygdrive/C/gap-4.10.1/pkg/digraphs-0.15.0/gap/digraph.gi:525
Error, was not in any namespace at /proc/cygdrive/C/gap-4.10.1/lib/variable.g:291 called from
LEAVE_NAMESPACE(  ); at /proc/cygdrive/C/gap-4.10.1/lib/package.gi:1253 called from
<function "ReadPackage">( <arguments> )
 called from read-eval loop at /proc/cygdrive/C/gap-4.10.1/pkg/digraphs-0.15.0/read.g:26
you can 'quit;' to quit to outer loop, or
you can 'return;' to continue
brk>

[wilfwilson]

@james-d-mitchell Any idea what we can do about this?

[james-d-mitchell]

@alex-konovalov @wilfwilson I don't really know what the problem is. Is this issue new, or did it always exist? I just had a look at the IO setup, for example, and it seems to be the same as Digraphs. Does IO work as expected on Windows? @ChrisJefferson @fingolfin any suggestions?

[olexandr-konovalov]

I haven't seen this before - prior to that, the build failed at an earlier stage as described in #138.

The IO package compiles to io.so, to the contrary.

[james-d-mitchell]

Ah, so what happens if you simply rename digraphs.dll to digraphs.so, I mean the actual executable?

[james-d-mitchell]

And sorry for not being more help, I don't have access to a windows computer so can't experiment.

[james-d-mitchell]

In IO's Makefile.am:

GAPINSTALLLIB = $(BINARCHDIR)/io.so
[....]
if SYS_IS_CYGWIN
	cp .libs/io.dll $(GAPINSTALLLIB)
else
	cp .libs/io.so $(GAPINSTALLLIB)
endif

In Digraphs,

GAPINSTALLLIB = $(abs_top_srcdir)/$(BINARCHDIR)/
[...]
if SYS_IS_CYGWIN
	cp .libs/digraphs.dll $(GAPINSTALLLIB)
else
	cp .libs/digraphs.so $(GAPINSTALLLIB)
endif

[james-d-mitchell]

So, it looks like in IO the .dll is simply renamed .so.

[wilfwilson]

Yes, in the io Makefile.am there is

BINARCHDIR = bin/$(GAPARCH)
GAPINSTALLLIB = $(BINARCHDIR)/io.so

so the command

cp .libs/io.dll $(GAPINSTALLLIB)

simply copies the dll to the same directory as usual, but renames it as io.so. But in Digraphs:

BINARCHDIR = bin/$(GAPARCH)
GAPINSTALLLIB = $(abs_top_srcdir)/$(BINARCHDIR)/

and so cp .libs/digraphs.dll $(GAPINSTALLLIB) is not renaming the .dll.

And is perhaps Digraphs putting the dll in the wrong place @james-d-mitchell? Note that GAPINSTALLLIB is defined differently in Digraphs compared with io. (No, because then it wouldn't work on Unix either...)

[wilfwilson]

(Sorry James I've repeated what you wrote, just wanted to look at it myself)

[wilfwilson]

I got access to a Windows machine and installed GAP 4.10.1 through the exe installer. I then renamed the .dll to .so:

 ┌───────┐   GAP 4.10.1 of 23-Feb-2019
 │  GAP  │   https://www.gap-system.org
 └───────┘   Architecture: i686-pc-cygwin-default32-kv3
 Configuration:  gmp 6.1.2, readline
 Loading the library and packages ...
 Packages:   AClib 1.3.1, Alnuth 3.1.0, AtlasRep 1.5.1, AutoDoc 2019.02.22,
             AutPGrp 1.10, Browse 1.8.8, CRISP 1.4.4, Cryst 4.1.18,
             CrystCat 1.1.8, CTblLib 1.2.2, FactInt 1.6.2, FGA 1.4.0,
             GAPDoc 1.6.2, IO 4.5.4, IRREDSOL 1.4, LAGUNA 3.9.2, Polenta 1.3.8,
             Polycyclic 2.14, PrimGrp 3.3.2, RadiRoot 2.8, ResClasses 4.7.1,
             SmallGrp 1.3, Sophus 1.24, SpinSym 1.5, TomLib 1.2.7,
             TransGrp 2.0.4, utils 0.61
 Try '??help' for help. See also '?copyright', '?cite' and '?authors'
gap> LoadPackage("io");
true
gap> LoadPackage("digraphs");
───────────────────────────────────────────────────────────────────────────────
Loading  orb 4.8.2 (Methods to enumerate orbits)
by Juergen Mueller (http://www.math.rwth-aachen.de/~Juergen.Mueller),
   Max Neunhöffer (http://www-groups.mcs.st-and.ac.uk/~neunhoef), and
   Felix Noeske (http://www.math.rwth-aachen.de/~Felix.Noeske).
Homepage: https://gap-packages.github.io/orb
───────────────────────────────────────────────────────────────────────────────
───────────────────────────────────────────────────────────────────────────────
Loading  GRAPE 4.8.1 (GRaph Algorithms using PErmutation groups)
by Leonard H. Soicher (http://www.maths.qmul.ac.uk/~lsoicher/).
Homepage: https://gap-packages.github.io/grape
───────────────────────────────────────────────────────────────────────────────
#W dlopen() error: No such file or directory
Error, module '/proc/cygdrive/C/gap-4.10.1/pkg/digraphs-0.15.0/bin/i686-pc-cygwin-defau\
lt32-kv3/digraphs.so' not found in
  if not LOAD_DYN( arg[1], false ) then
    Error( "no support for dynamic loading" );
fi; at /proc/cygdrive/C/gap-4.10.1/lib/files.gd:583 called from
<function "LoadDynamicModule">( <arguments> )
 called from read-eval loop at /proc/cygdrive/C/gap-4.10.1/pkg/digraphs-0.15.0/init.g:25
Error, was not in any namespace at /proc/cygdrive/C/gap-4.10.1/lib/variable.g:291 called from
LEAVE_NAMESPACE(  ); at /proc/cygdrive/C/gap-4.10.1/lib/package.gi:1253 called from
ReadPackage( pkgname, "init.g"
 ); at /proc/cygdrive/C/gap-4.10.1/lib/package.gi:1616 called from
<function "LoadPackage">( <arguments> )
 called from read-eval loop at *stdin*:2
you can 'quit;' to quit to outer loop, or
you can 'return;' to continue
brk>

[wilfwilson]

Note that the file really does seem to exist:

gap> IO_File("/proc/cygdrive/C/gap-4.10.1/pkg/digraphs-0.15.0/bin/i686-pc-cygwin-default32-kv3/digraphs.so");
<file fd=6 rbufsize=65536 rpos=1 rdata=0>

(i.e. it doesn't fail)

[james-d-mitchell]

What happens when you do:

  LoadDynamicModule(Filename(DirectoriesPackagePrograms("io"),
                             "io.so"));