Code Review #9
duguankuiAnnotations
12 warnings
|
build-test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, codecov/codecov-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
build-test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, codecov/codecov-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build-test:
src/Dignite.Cms.Domain.Shared/Dignite/Abp/Data/HasCustomFieldsExtensions.cs#L34
The variable 'exc' is declared but never used
|
|
build-test:
src/Dignite.Cms.Public.Application/Dignite/Cms/Public/Sections/SectionPublicAppService.cs#L56
XML comment is not placed on a valid language element
|
|
build-test:
test/Dignite.Cms.TestBase/Samples/SampleRepository_Tests.cs#L22
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build-test:
test/Dignite.Cms.Domain.Tests/Samples/SampleManager_Tests.cs#L16
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build-test:
test/Dignite.Cms.Application.Tests/Sites/SiteAppService_Tests.cs#L18
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build-test:
test/Dignite.Cms.Application.Tests/Sites/SiteAppService_Tests.cs#L27
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build-test:
test/Dignite.Cms.HttpApi.Client.ConsoleTestApp/ClientDemoService.cs#L39
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build-test:
host/Dignite.Cms.HttpApi.Host/Migrations/20230910024630_language-rename-to-region.cs#L8
The type name 'languagerenametoregion' only contains lower-cased ascii characters. Such names may become reserved for the language.
|
|
build-test:
host/Dignite.Cms.HttpApi.Host/Migrations/20230910024630_language-rename-to-region.Designer.cs#L17
The type name 'languagerenametoregion' only contains lower-cased ascii characters. Such names may become reserved for the language.
|
|
build-test:
host/Dignite.Cms.Blazor.Server.Host/Migrations/20230910024511_language-rename-to-region.cs#L8
The type name 'languagerenametoregion' only contains lower-cased ascii characters. Such names may become reserved for the language.
|