feat: do not copy memory when Uint8Array is pushed#48
Open
Gozala wants to merge 1 commit intodignifiedquire:masterfrom
Open
feat: do not copy memory when Uint8Array is pushed#48Gozala wants to merge 1 commit intodignifiedquire:masterfrom
Gozala wants to merge 1 commit intodignifiedquire:masterfrom
Conversation
vmx
approved these changes
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation will copy memory if
Uint8Arrayis pushed. Proposed change avoids unnecessary coping by creating a Buffer view of the underlyingArrayBufferinstead.