Add ranges to draft #1
Conversation
lib/draft.ex
Outdated
| input | ||
| |> Map.get("blocks") | ||
| |> Enum.map(&Draft.Block.to_html/1) | ||
| |> Enum.map(fn block -> Draft.Block.to_html(block, entity_map) end) |
There was a problem hiding this comment.
Purely style but I prefer the more compact
| |> Enum.map(fn block -> Draft.Block.to_html(block, entity_map) end) | |
| |> Enum.map(&(Draft.Block.to_html(&1, entity_map))) |
| [{0, 2}, {2, 4}, {4, 5}, {5, 8}] | ||
| """ | ||
| defp consolidate_ranges(ranges) do | ||
| ranges |
There was a problem hiding this comment.
So my one overall note on this (aside from it being somewhat hard to follow). Why not us Elixir's actual ranges for this? (didn't really consider that in light of adjusting ranges as the text is modified but it would make finding overlaps and inclusions a little simpler if they could be used)
There was a problem hiding this comment.
Great minds. I started using ranges, which 1. were introduced in 1.8, so I wasn't pumped about that in a lib, but moreover 2. they are always inclusive, so it was cumbersome translating to/from the ranges that come from draftjs (which can be easily treated as non-inclusive "ranges," but really the offset+length thing made for some rough overhead)
buob
force-pushed
the
jb/inline-and-entities
branch
from
cdfe851 to
678a4f3
Compare
Inline style ranges (right now only `BOLD` and `ITALIC`) and entity ranges (right now only `LINK`)
buob
force-pushed
the
jb/inline-and-entities
branch
from
678a4f3 to
5b6be92
Compare
Inline style ranges (right now only
BOLDandITALIC) and entityranges (right now only
LINK)