Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Husky + lint-staged #398

Merged
merged 12 commits into from
Nov 21, 2022
Merged

Add Husky + lint-staged #398

merged 12 commits into from
Nov 21, 2022

Conversation

theamrittimalsina
Copy link
Contributor

@theamrittimalsina theamrittimalsina commented Oct 14, 2022

Type of Change

  • Something else: Development tooling

What issue does this relate to?

resolves #396

What should this PR do?

Add husky and lint-staged

What are the acceptance criteria?

If all is correct, please add the tag 'hacktoberfest-accepted', Thanks

.husky/pre-commit Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@MattIPv4 MattIPv4 self-requested a review October 15, 2022 14:04
@MattIPv4 MattIPv4 changed the title Feature/husky and lint staged Add Husky + lint-staged Oct 18, 2022
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@MattIPv4
Copy link
Contributor

MattIPv4 commented Nov 3, 2022

👋 @amrittimalsina Just checking in to see if there's any progress here? If not, we'll close this PR so someone else can take a look at tackling this work :)

@MattIPv4
Copy link
Contributor

MattIPv4 commented Nov 8, 2022

With no further progress on this, closing.

@MattIPv4 MattIPv4 closed this Nov 8, 2022
@theamrittimalsina
Copy link
Contributor Author

sorry for being late, where can I push the new changes?

@MattIPv4
Copy link
Contributor

Ah, hey! Let me re-open the PR and you can continue here :)

@MattIPv4 MattIPv4 reopened this Nov 11, 2022
package.json Outdated Show resolved Hide resolved
@MattIPv4 MattIPv4 self-requested a review November 19, 2022 16:06
Copy link
Contributor

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MattIPv4 MattIPv4 merged commit c026007 into digitalocean:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Husky and lint-staged
2 participants