Add Japanese translation #368

Ippey · 2022-06-14T03:29:50Z

Type of Change

Something else: Add Japanese translation.

What issue does this relate to?

None

What should this PR do?

Add Japanese translation.
Add ja in each languages.js .

What are the acceptance criteria?

MattIPv4 · 2022-06-14T22:07:36Z

👋 Hey @Ippey, would you mind updating the Copyright xxxx value in the files you've modified to be 2022?

I've also just merged #366 which added two new strings that your language pack will need 💙

Tyvm!

Ippey · 2022-06-15T00:49:47Z

@MattIPv4 I've just modified it!

- templates.globalSections.performance.disableHtmlCaching - templates.globalSections.performance.enableDisableHtmlCaching

Ippey · 2022-06-15T13:41:17Z

I'm sorry. I added disableHtmlCaching, enableDisableHtmlCaching translation in ja. 🙏

5idereal · 2022-06-15T13:56:54Z

Hi, could you take a look at the suggestions I made above?

Ippey · 2022-06-15T14:21:08Z

Hi, @SiderealArt ! Does it mean that I have to modify year 20** to 2022 not only in the ja folder's files but also other languages files I modified?

5idereal · 2022-06-15T14:31:09Z

Yes, as @MattIPv4 said earlier.

Ippey · 2022-06-15T14:44:36Z

@MattIPv4 I also modified every languages.js.

Thank you, @SiderealArt !

5idereal · 2022-06-14T12:42:18Z

src/nginxconfig/i18n/de/languages.js

@@ -34,4 +34,5 @@ export default {
    ru: 'Russisch',
    pl: 'Polnisch',
    de: 'Deutsch',
+    ja: 'Japans',


Suggested change

ja: 'Japans',

ja: 'Japanisch',

5idereal · 2022-06-14T12:42:27Z

src/nginxconfig/i18n/en/languages.js

@@ -34,4 +34,5 @@ export default {
    ru: 'Russian',
    pl: 'Polish',
    de: 'German',
+    ja: 'Japans',


Suggested change

ja: 'Japans',

ja: 'Japanese',

5idereal · 2022-06-15T14:57:58Z

I forgot to click comment. I meant these suggestions. Sorry for bothering you again. 😥

MattIPv4

💙 Thank you for this translation -- a few quick thoughts:

MattIPv4 · 2022-06-15T11:16:34Z

src/nginxconfig/i18n/de/languages.js

@@ -34,4 +34,5 @@ export default {
    ru: 'Russisch',
    pl: 'Polnisch',
    de: 'Deutsch',
+    ja: 'Japans',


Suggested change

ja: 'Japans',

ja: 'Japanisch',

MattIPv4 · 2022-06-15T11:16:42Z

src/nginxconfig/i18n/en/languages.js

@@ -34,4 +34,5 @@ export default {
    ru: 'Russian',
    pl: 'Polish',
    de: 'German',
+    ja: 'Japans',


Suggested change

ja: 'Japans',

ja: 'Japanese',

MattIPv4 · 2022-06-15T11:19:55Z

src/nginxconfig/i18n/ja/common.js

+	back: '戻る',
+	next: '次へ',
+	enable: '有効にする',
+	php: 'PHP',
+	ssl: 'SSL',
+	nginx: 'NGINX',
+	http: 'HTTP',
+	https: 'HTTPS',
+	letsEncrypt: 'Let\'s Encrypt',
+	python: 'Python',
+	wordPress: 'WordPress',
+	drupal: 'Drupal',
+	magento: 'Magento',
+	joomla: 'Joomla',
+	django: 'Django',
+	logging: 'ログ',
+    reverseProxy: 'リバースプロキシ',
+    reverseProxyLower: 'リバースプロキシ',
+    restrict: '制限',
+    path: 'パス',


Suggested change

back: '戻る',

next: '次へ',

enable: '有効にする',

php: 'PHP',

ssl: 'SSL',

nginx: 'NGINX',

http: 'HTTP',

https: 'HTTPS',

letsEncrypt: 'Let\'s Encrypt',

python: 'Python',

wordPress: 'WordPress',

drupal: 'Drupal',

magento: 'Magento',

joomla: 'Joomla',

django: 'Django',

logging: 'ログ',

reverseProxy: 'リバースプロキシ',

reverseProxyLower: 'リバースプロキシ',

restrict: '制限',

path: 'パス',

back: '戻る',

next: '次へ',

enable: '有効にする',

php: 'PHP',

ssl: 'SSL',

nginx: 'NGINX',

http: 'HTTP',

https: 'HTTPS',

letsEncrypt: 'Let\'s Encrypt',

python: 'Python',

wordPress: 'WordPress',

drupal: 'Drupal',

magento: 'Magento',

joomla: 'Joomla',

django: 'Django',

logging: 'ログ',

reverseProxy: 'リバースプロキシ',

reverseProxyLower: 'リバースプロキシ',

restrict: '制限',

path: 'パス',

Looks like some tabs ended up in here, should be four space indents :)

MattIPv4 · 2022-06-15T11:21:58Z

src/nginxconfig/i18n/ja/languages.js

+    en: 'English',
+    es: 'Spanish',
+    zhCN: 'Chinese (simplified)',
+    zhTW: 'Chinese (traditional)',
+    ptBR: 'Portuguese (brazilian)',
+    fr: 'French',
+    ru: 'Russian',
+    pl: 'Polish',
+    de: 'German',


These can be translated to Japanese :)

MattIPv4 · 2022-06-15T11:27:59Z

src/nginxconfig/i18n/ja/templates/callouts/contribute.js

+
+export default {
+    wantToContributeChanges: '👋 新機能や変更の提案や実装、翻訳をしてみませんか?',
+    getInvolvedOnGitHub: 'Get involved on GitHub',


Should this be translated?

MattIPv4 · 2022-06-15T15:12:05Z

src/nginxconfig/i18n/ja/templates/global_sections/performance.js

+
+export default {
+    disableHtmlCaching: 'HTML キャッシュの無効化',
+    enableDisableHtmlCaching: 'TML キャッシュを無効にする',


Suggested change

enableDisableHtmlCaching: 'TML キャッシュを無効にする',

enableDisableHtmlCaching: 'HTML キャッシュを無効にする',

MattIPv4 · 2022-06-15T15:24:01Z

src/nginxconfig/i18n/ja/templates/setup_sections/go_live.js

+import common from '../../common';
+
+export default {
+    letsGoLive: 'Let\'s go live!',


Can this be translated?

MattIPv4 · 2022-06-15T15:24:05Z

src/nginxconfig/i18n/ja/templates/setup_sections/go_live.js

+export default {
+    letsGoLive: 'Let\'s go live!',
+    reloadNginxToLoadInYourNewConfiguration: `${common.nginx} をリロードして新しい設定を反映します:`,
+    goLive: 'Go live!',


Can this be translated?

MattIPv4 · 2022-06-15T15:27:23Z

src/nginxconfig/i18n/pl/languages.js

@@ -34,4 +34,5 @@ export default {
    ru: 'Rosyjski',
    pl: 'Polski',
    de: 'Niemiecki',
+    ja: 'Japonês',


Suggested change

ja: 'Japonês',

ja: 'Japoński',

Ippey · 2022-06-15T22:38:03Z

@MattIPv4 @SiderealArt Thank you for your suggestions. I corrected them.

MattIPv4

LGTM, thank you very much for contributing this! 💙

MattIPv4 · 2022-06-17T12:17:21Z

Hey, @Ippey - Thanks a ton for this sweet PR! 😄

Would you please shoot me an email when you get a chance?
mcowley at digitalocean dot com 🎉

Ippey added 2 commits June 15, 2022 10:44

Add Japanese.

cdd9d9c

Ippey force-pushed the add-ja branch from 8a1b3e1 to 2a04539 Compare June 15, 2022 01:44

update translations in ja.

5e840c1

- templates.globalSections.performance.disableHtmlCaching - templates.globalSections.performance.enableDisableHtmlCaching

5idereal reviewed Jun 15, 2022

View reviewed changes

MattIPv4 suggested changes Jun 15, 2022

View reviewed changes

correct according to review findings.

340757f

MattIPv4 approved these changes Jun 16, 2022

View reviewed changes

MattIPv4 merged commit 97b175a into digitalocean:master Jun 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Japanese translation #368

Add Japanese translation #368

Ippey commented Jun 14, 2022

MattIPv4 commented Jun 14, 2022

Ippey commented Jun 15, 2022

Ippey commented Jun 15, 2022

5idereal commented Jun 15, 2022

Ippey commented Jun 15, 2022

5idereal commented Jun 15, 2022

Ippey commented Jun 15, 2022

5idereal Jun 14, 2022

5idereal Jun 14, 2022

5idereal commented Jun 15, 2022

MattIPv4 left a comment

MattIPv4 Jun 15, 2022

MattIPv4 Jun 15, 2022

MattIPv4 Jun 15, 2022

MattIPv4 Jun 15, 2022

MattIPv4 Jun 15, 2022

MattIPv4 Jun 15, 2022

MattIPv4 Jun 15, 2022

MattIPv4 Jun 15, 2022

MattIPv4 Jun 15, 2022

Ippey commented Jun 15, 2022

MattIPv4 left a comment

MattIPv4 commented Jun 17, 2022

	enableDisableHtmlCaching: 'TML キャッシュを無効にする',
	enableDisableHtmlCaching: 'HTML キャッシュを無効にする',

Add Japanese translation #368

Add Japanese translation #368

Conversation

Ippey commented Jun 14, 2022

Type of Change

What issue does this relate to?

What should this PR do?

What are the acceptance criteria?

MattIPv4 commented Jun 14, 2022

Ippey commented Jun 15, 2022

Ippey commented Jun 15, 2022

5idereal commented Jun 15, 2022

Ippey commented Jun 15, 2022

5idereal commented Jun 15, 2022

Ippey commented Jun 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

5idereal commented Jun 15, 2022

MattIPv4 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ippey commented Jun 15, 2022

MattIPv4 left a comment

Choose a reason for hiding this comment

MattIPv4 commented Jun 17, 2022