Deserialize meta #286
Merged
Deserialize meta #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
force-pushed
the
deserialize-meta
branch
from
cdc9a4f to
a0a2c1d
Compare
added 2 commits
December 11, 2019 00:43
The fields only exist on collection-returning API operations.
timoreimann
force-pushed
the
deserialize-meta
branch
from
a0a2c1d to
b543023
Compare
zachgersh
approved these changes
Dec 11, 2019
bentranter
requested changes
Dec 11, 2019
There was a problem hiding this comment.
One note about the deprecated changelog file, other than that looks good to me. Thanks @timoreimann!
| @@ -1,5 +1,9 @@ | |||
| # Change Log | |||
|
|
|||
| ## unreleased | |||
There was a problem hiding this comment.
We've deprecated this changelog file in favour of using GitHub's release notes. Could you remove this entry?
There was a problem hiding this comment.
Okay never mind, looks like Zach merged this already. I can do this.
There was a problem hiding this comment.
Ohhh wait, I'm totally wrong, thought we did this here as well as doctl, but it's only for doctl. False alarm everyone 🤦♂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change deserializes the meta field into the response, allowing easy access to the total number of objects returned by API operations yielding collections.
We also remove links and meta fields from stubbed getters that do not return collections: according to the respective documentations, links and meta fields won't be included for single element responses.
For now, I have only implemented the change for storage (volumes and snapshots). I'd appreciate getting some initial feedback on the approach, after which I'm more than happy to support all other collection-returning API operations as well.