Remove betastorageservice, in production. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You don't need the type assertion anymore (mobile I can't line-comment ;) )
…On Wed, Nov 30, 2016 at 07:33 Phillip Baker ***@***.***> wrote:
Follow up to #108 <#108> based
on feedback. removes Beta Interface.
cc @aybabtme <https://github.com/aybabtme>
------------------------------
You can view, comment on, or merge this pull request online at:
#114
Commit Summary
- Remove betastorageservice, in production.
File Changes
- *M* storage.go
<https://github.com/digitalocean/godo/pull/114/files#diff-0> (12)
- *M* storage_test.go
<https://github.com/digitalocean/godo/pull/114/files#diff-1> (8)
Patch Links:
- https://github.com/digitalocean/godo/pull/114.patch
- https://github.com/digitalocean/godo/pull/114.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#114>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABInVMjCCrLpf2f14yMiPVsH3TTPogTxks5rDWzbgaJpZM4LAJBd>
.
|
phillbaker
force-pushed
the
update/storage-beta
branch
from
78fc638 to
f6b3415
Compare
|
Ah, thanks. Updated. |
aybabtme
suggested changes
Dec 1, 2016
| @@ -58,6 +58,8 @@ type Client struct { | |||
| Storage StorageService | |||
| StorageActions StorageActionsService | |||
| Tags TagsService | |||
| // Volume VolumeService | |||
There was a problem hiding this comment.
Gah, not sure how this got committed. Removed.
phillbaker
force-pushed
the
update/storage-beta
branch
from
f6b3415 to
786e78e
Compare
aybabtme
approved these changes
Dec 2, 2016
|
|
!
phillbaker
force-pushed
the
update/storage-beta
branch
from
786e78e to
8fdd58b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #108 based on feedback. removes
BetaInterface.cc @aybabtme