Dip on the data plane availability - 2025-08-24 #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayanjd-do
requested changes
Sep 16, 2025
registry/handlers/blobupload.go
Outdated
| defer buh.Upload.Close() | ||
|
|
||
| // Check if the client canceled the request | ||
| if r.Context().Err() != nil { |
There was a problem hiding this comment.
Hey @sanjaysingh916, imo we should also have this check for all handlers instead of just POST blob requests because when the docker client cancels it can cancel any underlying HTTP request. The best place to do that is in here. Lemme know if that makes sense.
|
@sanjaysingh916 Also, kindly check what nginx returns when client cancels the request (docr. LLMs suggest that it would return a non-standard status code 499. It might be possible that clients receive 499 regardless of what servers return. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dip on the data plane availability - 2025-08-24
DOCR-1675