-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: fix binary compilation #403
Conversation
- name: Check out code into the Go module directory | ||
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f | ||
|
||
- name: Verify docker image builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step should prevent us from merging PRs that don't build in the future.
@@ -18,18 +18,19 @@ else | |||
GIT_TREE_STATE=dirty | |||
endif | |||
|
|||
SHELL = bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use [[
somewhere in this Makefile that has been failing in CI and on my dev machine because the default GNU make
shell is sh
.
COMMIT ?= $(shell git rev-parse HEAD) | ||
BRANCH ?= $(shell git rev-parse --abbrev-ref HEAD) | ||
VERSION ?= $(shell cat VERSION) | ||
REGISTRY ?= digitalocean | ||
GO_VERSION ?= 1.15.2 | ||
GO_VERSION ?= 1.17.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes
Error: vendor/k8s.io/client-go/plugin/pkg/client/auth/exec/metrics.go:21:2: cannot find package "." in:
/go/src/github.com/digitalocean/digitalocean-cloud-controller-manager/vendor/io/fs
Error: make: *** [Makefile:68: compile] Error 1
sh
which doesn't have the[[
builtin)